[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ha-dev
Subject:    Re: [Linux-ha-dev] re:A patch of tomcat.
From:       Keisuke MORI <kskmori () intellilink ! co ! jp>
Date:       2009-02-25 8:21:08
Message-ID: u7i3fnczv.fsf () intellilink ! co ! jp
[Download RAW message or body]

Hi Dejan,

Thank you for reviewing it.

Commited the revised patch by Yamauchi-san (tomcat.patch-0225) as:
http://hg.linux-ha.org/dev/rev/6cbdca48bf88

Thanks,

Dejan Muhamedagic <dejanmm@fastmail.fm> writes:

> Hi,
>
> On Tue, Feb 24, 2009 at 12:20:22PM +0900, Keisuke MORI wrote:
>> Hi,
>> 
>> Will anybody review this patch?
>
> I was just reviewing it.
>
>> I can commit it to the -dev if there're no comments.
>> The patch was well tested and is used with tomcat 5.5 in our environment.
>
> Great. I'm attaching a patch which contains just a few
> minor optimizations and some meta-data updates. Please apply it
> after checking it with your tomcat (no tomcats here :).
>
> Cheers,
>
> Dejan
>
>> Thanks,
>> 
>> <renayama19661014@ybb.ne.jp> writes:
>> 
>> > Hi All, 
>> >
>> > The patch which solved a new problem was completed.
>> > The change is the following point. 
>> >
>> > 1. Addition of the comment. 
>> >
>> > 2. Deletion of the garbage in the log. 
>> >
>> > 3. Optional addition. 
>> >  * catalina_opts - CATALINA_OPTS environment variable. Default is None 
>> >  * catalina_rotate_log - Control catalina.out logrotation flag. Default is NO. 
>> >  * catalina_rotatetime - catalina.out logrotation time span(seconds). Default is 86400. 
>> >
>> > 4. I summarized redundant pgrep processing in one function.
>> >
>> > 5. Revised it so that pgrep was handled in a version of new tomcat definitely.
>> >  * The new version of tomcat confirmed that there was not a problem with 5.5.27 and version 6.0.28.
>> >
>> > 6. For unity, I revised it to use $WGET of ocf_shellfunc.
>> >
>> > I attached a patch. 
>> > Please reflect it in a development version. 
>> >
>> > Best Regards,
>> > Hideo Yamauchi.
>> >
>> > --- renayama19661014@ybb.ne.jp wrote:
>> >
>> >> Hi,
>> >> 
>> >> Sorry....
>> >> 
>> >> There was a problem to the patch which I attached.
>> >> When used latest tomcat, RA seem not to be able to handle it well.
>> >> 
>> >> I will send the patch which I revised later.
>> >> 
>> >> Best Regards,
>> >> 
>> >> Hideo Yamauchi.

-- 
Keisuke MORI
Open Source Business Unit
Software Services Integration Business Division
NTT DATA Intellilink Corporation
Tel: +81-3-3534-4810 / Fax: +81-3-3534-4814
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
[prev in list] [next in list] [prev in thread] [next in thread]