[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ha-dev
Subject:    Re: [Linux-ha-dev] [PATCH] sgi-ipmi: add plugin sgi-ipmi
From:       Lars Marowsky-Bree <lmb () suse ! de>
Date:       2008-10-27 10:18:39
Message-ID: 20081027101839.GD3192 () marowsky-bree ! de
[Download RAW message or body]

On 2008-10-27T13:31:41, Anibal Monsalve Salazar <anibal@sgi.com> wrote:

> Please add the sgi-ipmi plugin
> 
> The attached file is the sgi-ipmi plugin.
> 
> It supports SGI x86_64 systems based on both Intel and Supermicro BMCs.

Hi Anibal,

thanks for this submission! Before merging it, one or two questions:

First, we have an external/ipmi and a ipmilan fencing RA already; could
this not be folded into these? It seems extremly similar to the
external/ipmi one.

> # External STONITH module for ipmi.
> # This STONITH module takes two arguments:
> #   $1 is the operation
> #   $2 is the node to operate on
> # It takes a single environmental variable: nodelist
> # which is a space separated list of node definitions
> # Each Node definition consists of:
> #   nodename;userid;passwd;bmctype;ipaddr1[;ipaddrn]
> # Where:
> #   nodename is the hostname of a node
> #   userid   is the userid to use on the IPMI device
> #   passwd   is the password to use on the IPMI device
> #   bmctype  is the bmctype of the IPMI device (intel or supermicro)
> #   ipaddr   is the IP address of the IPMI device

I wonder if this is a good interface for configuration.

Would it not be cleaner to have one such resource per "nodelist" entry,
so that these would indeed be separate parameters, which the user then
could configure as such using the GUI/CLI?


Regards,
    Lars

-- 
Teamlead Kernel, SuSE Labs, Research and Development
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
"Experience is the name everyone gives to their mistakes." -- Oscar Wilde

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
[prev in list] [next in list] [prev in thread] [next in thread]