[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-ha-dev
Subject: Re: [Linux-ha-dev] Re: Patch for mysql OCF resource
From: Dejan Muhamedagic <dejanmm () fastmail ! fm>
Date: 2008-02-13 10:22:20
Message-ID: 20080213102219.GA26810 () rondo ! suse ! de
[Download RAW message or body]
Hi,
On Tue, Feb 12, 2008 at 10:16:34AM -0800, Narayan Newton wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Is it acceptable to have the RA parse the config file, then have it
> receive the config file path as an argument in the cib? I could see
> doing that to get rid of this defaults business.
I'd first like to see why there are so many. Hopefully, the set
could be reduced to something reasonable so that we wouldn't need
a config file.
Thanks,
Dejan
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
>
> iD8DBQFHseMDiZzbwJkJx6IRAkmmAKCR1Pdq4KxHMrlbbzFyLZKWDfwjUgCfbGy1
> FxFwImB+CJNDlgMG4YhYBKQ=
> =c8iU
> -----END PGP SIGNATURE-----
>
> On Feb 12, 2008 7:21 AM, Dejan Muhamedagic <dejanmm@fastmail.fm> wrote:
> > Hi,
> >
> > On Sun, Feb 10, 2008 at 05:23:59PM -0800, Narayan Newton wrote:
> > > -----BEGIN PGP SIGNED MESSAGE-----
> > > Hash: SHA1
> > >
> > > Well, that went nicely...I sent the wrong patch :).
> > >
> > > Attached is the right patch, with the socket and pidfile entries for
> > > gentoo correct.
> >
> > Thanks for the patch. Though I really dislike this defaults
> > tweaking business. Looks like every distribution and their
> > brother have different ideas about how to install mysql. If
> > somebody with mysql knowledge could reduce this set of OCF
> > variables it would be great. It's interesting that in no other, I
> > think at least, RA we have such a calamity of an environment.
> >
> > Thanks,
> >
> > Dejan
> >
> >
> > >
> > > -----BEGIN PGP SIGNATURE-----
> > > Version: GnuPG v1.4.7 (GNU/Linux)
> > >
> > > iD8DBQFHr6QyiZzbwJkJx6IRArqRAJ4ynXUobdX5dKbN6/RYg+vmjKA37ACdGAxB
> > > 5dLgJ7MnokfexihEGlIEhs4=
> > > =1p25
> > > -----END PGP SIGNATURE-----
> > >
> > > On Feb 10, 2008 4:27 PM, Narayan Newton <nnewton@osuosl.org> wrote:
> > > > -----BEGIN PGP SIGNED MESSAGE-----
> > > > Hash: SHA1
> > > >
> > > > Hi all,
> > > >
> > > > It would appear I'm going to be using the MySQL OCF resource agent in
> > > > the near future, so I am starting to work on it a bit. The attached
> > > > patch adds defaults for gentoo and debian as well as fixing one of the
> > > > global defaults, "mysqld_safe" instead of "safe_mysqld".
> > > >
> > > > I'm rather new to the community, so please let me know if I have
> > > > violated a community standard right off the bat or if you prefer
> > > > patches submitted in a different way/form. :) Thanks!
> > > >
> > > > - --
> > > > Narayan Newton
> > > > Database Administrator
> > > > OSU Open Source Lab
> > > > GA Member Drupal Association
> > > >
> > > > -----BEGIN PGP SIGNATURE-----
> > > > Version: GnuPG v1.4.7 (GNU/Linux)
> > > >
> > > > iD8DBQFHr5bqiZzbwJkJx6IRAjdWAKC+y5M3G3VCgX00zO2syI+2qfIxtgCfck0C
> > > > T08Kr+wjFgt+jJWm/+kcu+A=
> > > > =huzo
> > > > -----END PGP SIGNATURE-----
> > > >
> > >
> > >
> > >
> > > --
> > > Narayan Newton
> > > Database Administrator
> > > OSU Open Source Lab
> > > GA Member Drupal Association
> >
> > > diff -r 0ec715104599 resources/OCF/mysql
> > > --- a/resources/OCF/mysql Sun Feb 10 12:23:31 2008 +0100
> > > +++ b/resources/OCF/mysql Sun Feb 10 17:20:23 2008 -0800
> > > @@ -9,7 +9,8 @@
> > > # Author: Alan Robertson : DB2 Script
> > > # Author: Jakub Janczak : Rewrite as MySQL
> > > # Author: Andrew Beekhof : Cleanup and import
> > > -# Author: Sebastian Reitenbach : add OpenBSD defaults, more cleanup
> > > +# Author: Sebastian Reitenbach : add OpenBSD defaults, more cleanup
> > > +# Author: Narayan Newton : Add Gentoo/Debian defaults
> > > #
> > > # Support: linux-ha@lists.linux-ha.org
> > > # License: GNU General Public License (GPL)
> > > @@ -58,8 +59,36 @@ OCF_RESKEY_test_passwd_default=""
> > > OCF_RESKEY_test_passwd_default=""
> > > OCF_RESKEY_enable_creation_default=0
> > > OCF_RESKEY_additional_parameters_default=""
> > > +elif [ -f "/etc/gentoo-release" ]; then
> > > +OCF_RESKEY_binary_default="/usr/bin/mysqld_safe"
> > > +OCF_RESKEY_config_default="/etc/mysql/my.cnf"
> > > +OCF_RESKEY_datadir_default="/var/lib/mysql"
> > > +OCF_RESKEY_user_default="mysql"
> > > +OCF_RESKEY_group_default="mysql"
> > > +OCF_RESKEY_log_default="/var/log/mysql/mysqld.err"
> > > +OCF_RESKEY_pid_default="/var/run/mysqld/mysqld.pid"
> > > +OCF_RESKEY_socket_default="/var/run/mysqld/mysqld.sock"
> > > +OCF_RESKEY_test_user_default="root"
> > > +OCF_RESKEY_test_table_default="mysql.user"
> > > +OCF_RESKEY_test_passwd_default=""
> > > +OCF_RESKEY_enable_creation_default=0
> > > +OCF_RESKEY_additional_parameters_default=""
> > > +elif [ -f "/etc/debian_version" ]; then
> > > +OCF_RESKEY_binary_default="/usr/bin/mysqld_safe"
> > > +OCF_RESKEY_config_default="/etc/mysql/my.cnf"
> > > +OCF_RESKEY_datadir_default="/var/lib/mysql"
> > > +OCF_RESKEY_user_default="mysql"
> > > +OCF_RESKEY_group_default="mysql"
> > > +OCF_RESKEY_log_default="/var/log/mysql.log"
> > > +OCF_RESKEY_pid_default="/var/run/mysqld/mysqld.pid"
> > > +OCF_RESKEY_socket_default="/var/run/mysqld/mysqld.sock"
> > > +OCF_RESKEY_test_user_default="root"
> > > +OCF_RESKEY_test_table_default="mysql.user"
> > > +OCF_RESKEY_test_passwd_default=""
> > > +OCF_RESKEY_enable_creation_default=0
> > > +OCF_RESKEY_additional_parameters_default=""
> > > else
> > > -OCF_RESKEY_binary_default="/usr/bin/safe_mysqld"
> > > +OCF_RESKEY_binary_default="/usr/bin/mysqld_safe"
> > > OCF_RESKEY_config_default="/etc/my.cnf"
> > > OCF_RESKEY_datadir_default="/var/lib/mysql"
> > > OCF_RESKEY_user_default="mysql"
> >
> >
> > > _______________________________________________________
> > > Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
> > > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > > Home Page: http://linux-ha.org/
> >
> >
>
>
>
> --
> Narayan Newton
> Database Administrator
> OSU Open Source Lab
> GA Member Drupal Association
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic