[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ha-dev
Subject:    Re: [Linux-ha-dev] Re: [Linux-ha-cvs] Linux-HA CVS: lib by gshi from
From:       Guochun Shi <gshi () ncsa ! uiuc ! edu>
Date:       2005-10-31 22:12:56
Message-ID: 436696E8.4000609 () ncsa ! uiuc ! edu
[Download RAW message or body]

Andrew Beekhof wrote:

>On 10/31/05, linux-ha-cvs@lists.linux-ha.org
><linux-ha-cvs@lists.linux-ha.org> wrote:
>  
>
>>linux-ha CVS committal
>>
>>Author  : gshi
>>Host    :
>>Project : linux-ha
>>Module  : lib
>>
>>Dir     : linux-ha/lib/clplumbing
>>
>>
>>Modified Files:
>>        cl_msg.c
>>
>>
>>Log Message:
>>print out a warning if a big child msg is added
>>without using the compression method
>>
>>
>>===================================================================
>>RCS file: /home/cvs/linux-ha/linux-ha/lib/clplumbing/cl_msg.c,v
>>retrieving revision 1.88
>>retrieving revision 1.89
>>diff -u -3 -r1.88 -r1.89
>>--- cl_msg.c    20 Oct 2005 17:40:24 -0000      1.88
>>+++ cl_msg.c    31 Oct 2005 17:36:30 -0000      1.89
>>@@ -1,4 +1,4 @@
>>-/* $Id: cl_msg.c,v 1.88 2005/10/20 17:40:24 gshi Exp $ */
>>+/* $Id: cl_msg.c,v 1.89 2005/10/31 17:36:30 gshi Exp $ */
>> /*
>>  * Heartbeat messaging object.
>>  *
>>@@ -50,6 +50,8 @@
>> #define                MAX_INT_LEN     64
>> #define                MAX_NAME_LEN    255
>> #define                UUID_SLEN       64
>>+#define                MAXCHILDMSGLEN  512
>>+
>> static int     compression_threshold = (2*1024);
>>
>> static enum cl_msgfmt msgfmt = MSGFMT_NVPAIR;
>>@@ -692,6 +694,15 @@
>> int
>> ha_msg_addstruct(struct ha_msg * msg, const char * name, const void * value)
>> {
>>+       const struct ha_msg* childmsg = (const struct ha_msg*) value;
>>+
>>+       if (get_netstringlen(childmsg) > MAXCHILDMSGLEN
>>+           || get_stringlen(childmsg) > MAXCHILDMSGLEN){
>>+               cl_log(LOG_WARNING, "%s: childmsg too long)(%d %d), You should use"
>>+                      " ha_msg_addstruct_compress() instead",__FUNCTION__,
>>+                      get_netstringlen(childmsg),
>>+                      get_stringlen(childmsg));
>>+       }
>>    
>>
>
>any chance you could include name in the log message?
>
>  
>
ok, Done

-Guochun


_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
[prev in list] [next in list] [prev in thread] [next in thread]