[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ha-dev
Subject:    Re: [Linux-ha-dev] crmtest build problem
From:       Andrew Beekhof <beekhof () gmail ! com>
Date:       2005-10-28 12:39:26
Message-ID: 26ef5e70510280539k7035570cva8043b61ce5de2ad () mail ! gmail ! com
[Download RAW message or body]

On 10/28/05, Horms <horms@verge.net.au> wrote:
> On Thu, Oct 27, 2005 at 04:56:48PM +0200, Andrew Beekhof wrote:
> > On 10/27/05, Horms <horms@verge.net.au> wrote:
> > > Hi,
> > >
> > > while building 2.0.2, for what must be at least the 100th time,
> > > I found a problem that hadn't manifested before. crm/test/Makefile.am
> > > creates $(testdir) in install-exec-local, but its aready being created
> > > anyway, because automake knows scripts go in there. Why this causes
> > > breakage, I'm not sure, but it was reproducable, so I guess its
> > > a real, though uncommon problem.
> > >
> > > On peeking in crm/test/Makefile.am I found some other intersting things
> > > that I have changed.
> > >
> > > * install-exec-local should probably be install-data-local
> > >   as SCRIPTS are data, not exec
> > > * EXTRA_DIST shouldn't need to list files that are already listed
> > >   in SCRIPTS. Thats all its lists, so I removed it.
> > > * the install-exec-local (install-data-local) shouldn't need
> > >   to create $(testdir), as explained above
> > > * Reinstage chmod, shich seems to have been commented out
> > >   as part of an artifact of another commit, let me know if this
> > >   is wrong.
> > >   http://cvs.linux-ha.org/viewcvs/viewcvs.cgi/linux-ha/crm/test/Makefile.am?rev=1.12&view=log
> > >
> >
> > if BSC still runs afterwards I have no problem with the changes :-)
>
> chmod seems like the only candidate that could break BSC, and even
> that seems slim. I'll put my change in, feel free to back it
> out if it causes bother, and I'll cook up another version.

looks fine to me - thanks!
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

[prev in list] [next in list] [prev in thread] [next in thread]