[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ha-dev
Subject:    [Linux-ha-dev] linux-ha/heartbeat/ha_msg_internal.c - diff - 1.48
From:       Alan Robertson <alanr () unix ! sh>
Date:       2005-02-11 4:55:41
Message-ID: 420C3ACD.1040400 () unix ! sh
[Download RAW message or body]

Someone renamed the static functions ha_msg_timestamp() and also 
ha_msg_ttl()!!!

Why, did someone come into this function, rename it completely 
inconsistently with what was there, and mangle the spelling while they were 
at it???

At first I thought it was just playing mind games - but now I think it was 
just an incredibly sloppy global change.

If you're going to make a global change - make sure it's only in your code, 
and not in someone else's.  Show a little concern, please.

	Thank you!


<http://cvs.linux-ha.org/viewcvs/viewcvs.cgi/linux-ha/heartbeat/ha_msg_internal.c.diff?r1=1.47&r2=1.48>

-- 
     Alan Robertson <alanr@unix.sh>

"Openness is the foundation and preservative of friendship...  Let me claim 
from you at all times your undisguised opinions." - William Wilberforce

["cvs.linux-ha.org/viewcvs/viewcvs.cgi/linux-ha/heartbeat/ha_msg_internal.c.diff?r1=1.47&r2=1.48" (text/html)]

<html><head>
<!-- ViewCVS -- http://viewcvs.sourceforge.net/
by Greg Stein -- mailto:gstein@lyra.org
-->

<title>linux-ha/heartbeat/ha_msg_internal.c - diff - 1.48</title>
</head>
<body bgcolor="#eeeeee">
<table width="100%" border=0 cellspacing=0 cellpadding=1 bgcolor="#9999ee">
<tr valign=bottom>
<td>
<a href="ha_msg_internal.c#rev1.48">
<img src="/viewcvs/icons/back.gif" alt="(file)" border=0 width=16 height=16>
</a>
<b>Return to
<a href="ha_msg_internal.c#rev1.48">ha_msg_internal.c</a>
CVS log</b>
<img src="/viewcvs/icons/text.gif" alt="(file)" border=0 width=16 height=16>
</td>
<td align=right>
<img src="/viewcvs/icons/dir.gif" alt="(dir)" border=0 width=16 height=16>
<b>Up to <a href="/viewcvs/viewcvs.cgi/#dirlist">[Linux-HA]</a> / <a \
href="/viewcvs/viewcvs.cgi/linux-ha/#dirlist">linux-ha</a> / <a \
href="/viewcvs/viewcvs.cgi/linux-ha/heartbeat/#dirlist">heartbeat</a></b> </td>
</tr>
</table>

<h3 align=center>Diff for /linux-ha/heartbeat/ha_msg_internal.c between version 1.47 \
and 1.48</h3> <table border=0 cellspacing=0 cellpadding=0 width="100%">
<tr bgcolor=white>
<th width="50%" valign=top>
version 1.47, 2004/08/31 17:35:13

</th>
<th width="50%" valign=top>
version 1.48, 2005/01/18 20:33:03

</th>
</tr>


<tr bgcolor="#99cccc"><td width="50%">
<table width="100%" border=1 cellpadding=5><tr>
<td><b>Line 57</b>&nbsp;<font
size="-1"></font></td>
</tr></table></td><td width="50%">
<table width="100%" border=1 cellpadding=5><tr>
<td><b>Line 57</b>&nbsp;<font
size="-1"></font></td>
</tr></table>
</td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp;};</font></td><td><font \
face="Helvetica,Arial" size="-1">&nbsp;};</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp;</font></td><td><font \
face="Helvetica,Arial" size="-1">&nbsp;</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp;static &nbsp;const char * \
ha_msg_seq(void);</font></td><td><font face="Helvetica,Arial" size="-1">&nbsp;static \
&nbsp;const char * ha_msg_seq(void);</font></td></tr>






<tr>
<td bgcolor="#ffff77"><font face="Helvetica,Arial" size="-1">&nbsp;static &nbsp;const \
char * ha_msg_timestamp(void);</font></td>

<td bgcolor="#ffff77"><font face="Helvetica,Arial" size="-1">&nbsp;static &nbsp;const \
char * HA_Messageimestamp(void);</font></td>

</tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp;static &nbsp;const char * \
ha_msg_loadavg(void);</font></td><td><font face="Helvetica,Arial" \
size="-1">&nbsp;static &nbsp;const char * ha_msg_loadavg(void);</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp;static &nbsp;const char * \
ha_msg_from(void);</font></td><td><font face="Helvetica,Arial" size="-1">&nbsp;static \
&nbsp;const char * ha_msg_from(void);</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp;static &nbsp;const char * \
ha_msg_fromuuid(void);</font></td><td><font face="Helvetica,Arial" \
size="-1">&nbsp;static &nbsp;const char * ha_msg_fromuuid(void);</font></td></tr>






<tr>
<td bgcolor="#ffff77"><font face="Helvetica,Arial" size="-1">&nbsp;static &nbsp;const \
char * ha_msg_ttl(void);</font></td>

<td bgcolor="#ffff77"><font face="Helvetica,Arial" size="-1">&nbsp;static &nbsp;const \
char * HA_Messagetl(void);</font></td>

</tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp;static &nbsp;const char * \
ha_msg_hbgen(void);</font></td><td><font face="Helvetica,Arial" \
size="-1">&nbsp;static &nbsp;const char * ha_msg_hbgen(void);</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp;</font></td><td><font \
face="Helvetica,Arial" size="-1">&nbsp;</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp;/* Each of these functions \
returns static data requiring copying */</font></td><td><font face="Helvetica,Arial" \
size="-1">&nbsp;/* Each of these functions returns static data requiring copying \
*/</font></td></tr>



<tr bgcolor="#99cccc"><td width="50%">
<table width="100%" border=1 cellpadding=5><tr>
<td><b>Line 70</b>&nbsp;<font
size="-1"></font></td>
</tr></table></td><td width="50%">
<table width="100%" border=1 cellpadding=5><tr>
<td><b>Line 70</b>&nbsp;<font
size="-1"></font></td>
</tr></table>
</td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp;{F_ORIGUUID, &nbsp; &nbsp;ha_msg_fromuuid, 2},</font></td><td><font \
face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;{F_ORIGUUID, \
&nbsp; &nbsp;ha_msg_fromuuid, 2},</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp;{F_SEQ, &nbsp; &nbsp; &nbsp; &nbsp; ha_msg_seq, &nbsp; &nbsp; \
1},</font></td><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp;{F_SEQ, &nbsp; &nbsp; &nbsp; &nbsp; ha_msg_seq, &nbsp; &nbsp; \
1},</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp;{F_HBGENERATION,ha_msg_hbgen, &nbsp; 0},</font></td><td><font \
face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp;{F_HBGENERATION,ha_msg_hbgen, &nbsp; 0},</font></td></tr>






<tr>
<td bgcolor="#ffff77"><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp;{F_TIME, &nbsp; &nbsp; &nbsp; &nbsp;ha_msg_timestamp,0},</font></td>

<td bgcolor="#ffff77"><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp;{F_TIME, &nbsp; &nbsp; &nbsp; &nbsp;HA_Messageimestamp,0},</font></td>

</tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp;{F_LOAD, &nbsp; &nbsp; &nbsp; &nbsp;ha_msg_loadavg, 1},</font></td><td><font \
face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;{F_LOAD, &nbsp; \
&nbsp; &nbsp; &nbsp;ha_msg_loadavg, 1},</font></td></tr>






<tr>
<td bgcolor="#ffff77"><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp;{F_TTL, &nbsp; &nbsp; &nbsp; &nbsp; ha_msg_ttl, 0},</font></td>

<td bgcolor="#ffff77"><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp;{F_TTL, &nbsp; &nbsp; &nbsp; &nbsp; HA_Messagetl, 0},</font></td>

</tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp;};</font></td><td><font \
face="Helvetica,Arial" size="-1">&nbsp;};</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp;</font></td><td><font \
face="Helvetica,Arial" size="-1">&nbsp;</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp;struct ha_msg \
*</font></td><td><font face="Helvetica,Arial" size="-1">&nbsp;struct ha_msg \
*</font></td></tr>



<tr bgcolor="#99cccc"><td width="50%">
<table width="100%" border=1 cellpadding=5><tr>
<td><b>Line 118</b>&nbsp;<font
size="-1"></font></td>
</tr></table></td><td width="50%">
<table width="100%" border=1 cellpadding=5><tr>
<td><b>Line 118</b>&nbsp;<font
size="-1"></font></td>
</tr></table>
</td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp;</font></td><td><font \
face="Helvetica,Arial" size="-1">&nbsp;</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;if \
((type = ha_msg_value(ret, F_TYPE)) == NULL) {</font></td><td><font \
face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;if ((type = \
ha_msg_value(ret, F_TYPE)) == NULL) {</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp; &nbsp; &nbsp;ha_log(LOG_ERR, "No type (add_control_msg_fields): \
");</font></td><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;ha_log(LOG_ERR, "No type (add_control_msg_fields): \
");</font></td></tr>






<tr>
<td bgcolor="#ffff77"><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;cl_log_message(ret);</font></td>

<td bgcolor="#ffff77"><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;cl_log_message(LOG_ERR, ret);</font></td>

</tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp; &nbsp; &nbsp;ha_msg_del(ret);</font></td><td><font \
face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp;ha_msg_del(ret);</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp; &nbsp; &nbsp;return(NULL);</font></td><td><font face="Helvetica,Arial" \
size="-1">&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp;return(NULL);</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp;}</font></td><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp;}</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp;</font></td><td><font \
face="Helvetica,Arial" size="-1">&nbsp;</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;if \
(DEBUGPKTCONT) {</font></td><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; \
&nbsp; &nbsp; &nbsp;if (DEBUGPKTCONT) {</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp; &nbsp; &nbsp;ha_log(LOG_DEBUG, "add_control_msg_fields: input \
packet");</font></td><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;ha_log(LOG_DEBUG, "add_control_msg_fields: \
input packet");</font></td></tr>






<tr>
<td bgcolor="#ffff77"><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;cl_log_message(ret);</font></td>

<td bgcolor="#ffff77"><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;cl_log_message(LOG_DEBUG, ret);</font></td>

</tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp;}</font></td><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp;}</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp;</font></td><td><font \
face="Helvetica,Arial" size="-1">&nbsp;</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp;noseqno = (strncmp(type, NOSEQ_PREFIX, sizeof(NOSEQ_PREFIX)-1) == \
0);</font></td><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp;noseqno = (strncmp(type, NOSEQ_PREFIX, sizeof(NOSEQ_PREFIX)-1) == \
0);</font></td></tr>



<tr bgcolor="#99cccc"><td width="50%">
<table width="100%" border=1 cellpadding=5><tr>
<td><b>Line 174</b>&nbsp;<font
size="-1"></font></td>
</tr></table></td><td width="50%">
<table width="100%" border=1 cellpadding=5><tr>
<td><b>Line 174</b>&nbsp;<font
size="-1"></font></td>
</tr></table>
</td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp;}</font></td><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp;}</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;if \
(DEBUGPKTCONT) {</font></td><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; \
&nbsp; &nbsp; &nbsp;if (DEBUGPKTCONT) {</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp; &nbsp; &nbsp;ha_log(LOG_DEBUG, "add_control_msg_fields: packet \
returned");</font></td><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; \
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;ha_log(LOG_DEBUG, \
"add_control_msg_fields: packet returned");</font></td></tr>






<tr>
<td bgcolor="#ffff77"><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;cl_log_message(ret);</font></td>

<td bgcolor="#ffff77"><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;cl_log_message(LOG_DEBUG, ret);</font></td>

</tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp;}</font></td><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp;}</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp;</font></td><td><font \
face="Helvetica,Arial" size="-1">&nbsp;</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp;return ret;</font></td><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; \
&nbsp; &nbsp; &nbsp;return ret;</font></td></tr>



<tr bgcolor="#99cccc"><td width="50%">
<table width="100%" border=1 cellpadding=5><tr>
<td><b>Line 204</b>&nbsp;<font
size="-1"></font></td>
</tr></table></td><td width="50%">
<table width="100%" border=1 cellpadding=5><tr>
<td><b>Line 204</b>&nbsp;<font
size="-1"></font></td>
</tr></table>
</td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;, &nbsp; &nbsp; &nbsp; \
"add_msg_auth: %s: &nbsp;from %s"</font></td><td><font face="Helvetica,Arial" \
size="-1">&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp; &nbsp;, &nbsp; &nbsp; &nbsp; "add_msg_auth: %s: &nbsp;from \
%s"</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;, &nbsp; &nbsp; &nbsp; \
"missing from/ts/type"</font></td><td><font face="Helvetica,Arial" size="-1">&nbsp; \
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;, \
&nbsp; &nbsp; &nbsp; "missing from/ts/type"</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;, &nbsp; &nbsp; &nbsp; (from? \
from : "&lt;?&gt;"));</font></td><td><font face="Helvetica,Arial" size="-1">&nbsp; \
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;, \
&nbsp; &nbsp; &nbsp; (from? from : "&lt;?&gt;"));</font></td></tr>






<tr>
<td bgcolor="#ffff77"><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp;cl_log_message(m);</font></td>

<td bgcolor="#ffff77"><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp;cl_log_message(LOG_ERR, m);</font></td>

</tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp; &nbsp; &nbsp;}</font></td><td><font face="Helvetica,Arial" \
size="-1">&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp;}</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp;}</font></td><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp;}</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp;</font></td><td><font \
face="Helvetica,Arial" size="-1">&nbsp;</font></td></tr>



<tr bgcolor="#99cccc"><td width="50%">
<table width="100%" border=1 cellpadding=5><tr>
<td><b>Line 336</b>&nbsp;<font
size="-1"></font></td>
</tr></table></td><td width="50%">
<table width="100%" border=1 cellpadding=5><tr>
<td><b>Line 336</b>&nbsp;<font
size="-1"></font></td>
</tr></table>
</td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp;</font></td><td><font \
face="Helvetica,Arial" size="-1">&nbsp;</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp;/* Add local timestamp field \
*/</font></td><td><font face="Helvetica,Arial" size="-1">&nbsp;/* Add local timestamp \
field */</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp;STATIC &nbsp;const char \
*</font></td><td><font face="Helvetica,Arial" size="-1">&nbsp;STATIC &nbsp;const char \
*</font></td></tr>






<tr>
<td bgcolor="#ffff77"><font face="Helvetica,Arial" \
size="-1">&nbsp;ha_msg_timestamp(void)</font></td>

<td bgcolor="#ffff77"><font face="Helvetica,Arial" \
size="-1">&nbsp;HA_Messageimestamp(void)</font></td>

</tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp;{</font></td><td><font \
face="Helvetica,Arial" size="-1">&nbsp;{</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp;static char ts[32];</font></td><td><font face="Helvetica,Arial" \
size="-1">&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;static char ts[32];</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp;sprintf(ts, TIME_X, (TIME_T)time(NULL));</font></td><td><font \
face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;sprintf(ts, \
TIME_X, (TIME_T)time(NULL));</font></td></tr>



<tr bgcolor="#99cccc"><td width="50%">
<table width="100%" border=1 cellpadding=5><tr>
<td><b>Line 378</b>&nbsp;<font
size="-1"></font></td>
</tr></table></td><td width="50%">
<table width="100%" border=1 cellpadding=5><tr>
<td><b>Line 378</b>&nbsp;<font
size="-1"></font></td>
</tr></table>
</td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp;}</font></td><td><font \
face="Helvetica,Arial" size="-1">&nbsp;}</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp;</font></td><td><font \
face="Helvetica,Arial" size="-1">&nbsp;</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp;STATIC &nbsp;const char \
*</font></td><td><font face="Helvetica,Arial" size="-1">&nbsp;STATIC &nbsp;const char \
*</font></td></tr>






<tr>
<td bgcolor="#ffff77"><font face="Helvetica,Arial" \
size="-1">&nbsp;ha_msg_ttl(void)</font></td>

<td bgcolor="#ffff77"><font face="Helvetica,Arial" \
size="-1">&nbsp;HA_Messagetl(void)</font></td>

</tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp;{</font></td><td><font \
face="Helvetica,Arial" size="-1">&nbsp;{</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp;static char &nbsp; &nbsp; ttl[8];</font></td><td><font face="Helvetica,Arial" \
size="-1">&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;static char &nbsp; &nbsp; \
ttl[8];</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp;snprintf(ttl, sizeof(ttl), "%d", config-&gt;hopfudge + \
config-&gt;nodecount);</font></td><td><font face="Helvetica,Arial" size="-1">&nbsp; \
&nbsp; &nbsp; &nbsp; &nbsp;snprintf(ttl, sizeof(ttl), "%d", config-&gt;hopfudge + \
config-&gt;nodecount);</font></td></tr>



<tr bgcolor="#99cccc"><td width="50%">
<table width="100%" border=1 cellpadding=5><tr>
<td><b>Line 416</b>&nbsp;<font
size="-1"></font></td>
</tr></table></td><td width="50%">
<table width="100%" border=1 cellpadding=5><tr>
<td><b>Line 416</b>&nbsp;<font
size="-1"></font></td>
</tr></table>
</td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp;#endif</font></td><td><font \
face="Helvetica,Arial" size="-1">&nbsp;#endif</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp;/*</font></td><td><font \
face="Helvetica,Arial" size="-1">&nbsp;/*</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp; * $Log$</font></td><td><font \
face="Helvetica,Arial" size="-1">&nbsp; * $Log$</font></td></tr>




<tr>
<td bgcolor="#cccccc">&nbsp;</td>
<td bgcolor="#aaffaa"><font face="Helvetica,Arial" size="-1">&nbsp; * Revision 1.48 \
&nbsp;2005/01/18 20:33:03 &nbsp;andrew</font></td> </tr>




<tr>
<td bgcolor="#cccccc">&nbsp;</td>
<td bgcolor="#aaffaa"><font face="Helvetica,Arial" size="-1">&nbsp; * Appologies for \
the top-level commit, one change necessitated another which</font></td> </tr>




<tr>
<td bgcolor="#cccccc">&nbsp;</td>
<td bgcolor="#aaffaa"><font face="Helvetica,Arial" size="-1">&nbsp; * &nbsp; exposed \
some bugs... etc etc</font></td> </tr>




<tr>
<td bgcolor="#cccccc">&nbsp;</td>
<td bgcolor="#aaffaa"><font face="Helvetica,Arial" size="-1">&nbsp; *</font></td>
</tr>




<tr>
<td bgcolor="#cccccc">&nbsp;</td>
<td bgcolor="#aaffaa"><font face="Helvetica,Arial" size="-1">&nbsp; * Remove \
redundant usage of XML in the CRM</font></td> </tr>




<tr>
<td bgcolor="#cccccc">&nbsp;</td>
<td bgcolor="#aaffaa"><font face="Helvetica,Arial" size="-1">&nbsp; * - switch to \
"struct ha_msg" aka. HA_Message for everything except data</font></td> </tr>




<tr>
<td bgcolor="#cccccc">&nbsp;</td>
<td bgcolor="#aaffaa"><font face="Helvetica,Arial" size="-1">&nbsp; * Make sure the \
expected type of all FSA input data is verified before processing</font></td> </tr>




<tr>
<td bgcolor="#cccccc">&nbsp;</td>
<td bgcolor="#aaffaa"><font face="Helvetica,Arial" size="-1">&nbsp; * Fix a number of \
bugs including</font></td> </tr>




<tr>
<td bgcolor="#cccccc">&nbsp;</td>
<td bgcolor="#aaffaa"><font face="Helvetica,Arial" size="-1">&nbsp; * - looking in \
the wrong place for the API result data in the CIB API</font></td> </tr>




<tr>
<td bgcolor="#cccccc">&nbsp;</td>
<td bgcolor="#aaffaa"><font face="Helvetica,Arial" size="-1">&nbsp; * &nbsp; (hideous \
that this actually worked).</font></td> </tr>




<tr>
<td bgcolor="#cccccc">&nbsp;</td>
<td bgcolor="#aaffaa"><font face="Helvetica,Arial" size="-1">&nbsp; * - not \
overwriting error codes when sending the result to the client in the CIB \
API</font></td> </tr>




<tr>
<td bgcolor="#cccccc">&nbsp;</td>
<td bgcolor="#aaffaa"><font face="Helvetica,Arial" size="-1">&nbsp; * &nbsp; (this \
lead to some error cases being treated as successes later in the code)</font></td> \
</tr>




<tr>
<td bgcolor="#cccccc">&nbsp;</td>
<td bgcolor="#aaffaa"><font face="Helvetica,Arial" size="-1">&nbsp; * Add PID to log \
messages sent to files (not to syslog)</font></td> </tr>




<tr>
<td bgcolor="#cccccc">&nbsp;</td>
<td bgcolor="#aaffaa"><font face="Helvetica,Arial" size="-1">&nbsp; * Add a log level \
to calls for cl_log_message()</font></td> </tr>




<tr>
<td bgcolor="#cccccc">&nbsp;</td>
<td bgcolor="#aaffaa"><font face="Helvetica,Arial" size="-1">&nbsp; * - convert \
existing calls, sorry if I got the level wrong</font></td> </tr>




<tr>
<td bgcolor="#cccccc">&nbsp;</td>
<td bgcolor="#aaffaa"><font face="Helvetica,Arial" size="-1">&nbsp; * Add some checks \
in cl_msg.c code to prevent NULL pointer exceptions</font></td> </tr>




<tr>
<td bgcolor="#cccccc">&nbsp;</td>
<td bgcolor="#aaffaa"><font face="Helvetica,Arial" size="-1">&nbsp; * - usually when \
NULL is passed to strlen() or similar</font></td> </tr>




<tr>
<td bgcolor="#cccccc">&nbsp;</td>
<td bgcolor="#aaffaa"><font face="Helvetica,Arial" size="-1">&nbsp; *</font></td>
</tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp; * Revision 1.47 \
&nbsp;2004/08/31 17:35:13 &nbsp;alan</font></td><td><font face="Helvetica,Arial" \
size="-1">&nbsp; * Revision 1.47 &nbsp;2004/08/31 17:35:13 \
&nbsp;alan</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp; * Put in a "be quiet on format \
errors" change I had missed before...</font></td><td><font face="Helvetica,Arial" \
size="-1">&nbsp; * Put in a "be quiet on format errors" change I had missed \
before...</font></td></tr>







<tr><td><font face="Helvetica,Arial" size="-1">&nbsp; *</font></td><td><font \
face="Helvetica,Arial" size="-1">&nbsp; *</font></td></tr>


</table><br><hr noshade width="100%">
<table border=0 cellpadding=10><tr><td>
<table border=1><tr><td>Legend:<br>
<table border=0 cellspacing=0 cellpadding=1>
<tr>
<td align=center bgcolor="#ffaaaa">Removed from v.1.47</td>
<td bgcolor="#cccccc">&nbsp;</td>
</tr>
<tr bgcolor="#ffff77"><td align=center colspan=2>changed lines</td></tr>
<tr>
<td bgcolor="#cccccc">&nbsp;</td>
<td align=center bgcolor="#aaffaa">Added in v.1.48</td>
</tr>
</table></td></tr></table></td>
<td><form method="GET" \
action="/viewcvs/viewcvs.cgi/linux-ha/heartbeat/ha_msg_internal.c.diff"> <input \
type=hidden name="r1" value="1.47"><input type=hidden name="r2" value="1.48"> <select \
name="diff_format" onchange="submit()"> <option value="h" selected>Colored \
Diff</option> <option value="l" >Long Colored Diff</option>
<option value="u" >Unidiff</option>
<option value="c" >Context Diff</option>
<option value="s" >Side by Side</option>
</select>
<input type=submit value="Show">
</form></td></tr>
</table>

<hr noshade>
<table width="100%" border=0 cellpadding=0 cellspacing=0><tr>
<td align=left><address><a href="mailto:cvs-admin@newcommunity.tummy.com">CVS \
Admin</a></address></td> <td align=right>
Powered by<br><a href="http://viewcvs.sourceforge.net/">ViewCVS 0.9.2</a>
</td></tr></table>
</body></html>



_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic