[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-ha-dev
Subject: Re: [Linux-ha-dev] RFC: CCM Patch (last call)
From: Andrew Beekhof <andrew-ha () beekhof ! homelinux ! net>
Date: 2004-03-19 10:20:51
Message-ID: 20040319112051.163f5920.andrew-ha () beekhof ! homelinux ! net
[Download RAW message or body]
Thanks for the tip Ram, I'll get onto it pronto :)
On 18 Mar 2004 19:05:07 -0800
Ram Pai <linuxram@us.ibm.com> wrote:
>
> > +
> > + /* strdup(uname) needs to be cleaned up somewhere
> > + * but I cant see where
> > + */
> > +
> > + newmbr->m_mem.m_array[j].node_uname = strdup(uname);
>
>
> This memory has to be freed. It has to be done wherever
> g_free(mem_track); is called.
>
> I suggest writing a g_mem_track_free(mem_track) and calling it
> whereever g_free(mem_track) is called. It is I think called in three
> places.
>
>
>
> something around these lines.
>
> mem_track_free(mem_track)
> {
> for (i = 0 ; i < no of members; i ++ )
> g_free(mem_track->m_mem.m_array[j].node_uname);
> }
> g_free(mem_track);
> }
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic