[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ha-dev
Subject:    Re: [Linux-ha-dev] [PATCH] Enable CCM on the new socket IPC layer
From:       "Zhu, Yi" <yi.zhu () intel ! com>
Date:       2004-02-17 4:40:00
Message-ID: Pine.LNX.4.44.0402171025100.8399-100000 () mazda ! sh ! intel ! com
[Download RAW message or body]

On Fri, 13 Feb 2004, Lars Marowsky-Bree wrote:

> ccm_readmsg() is only called once in the code, and hasn't used the
> timeout parameter in the past (ie, it was always called with a 0
> timeout). Your new change removes the timeout from the ccm_readmsg()
> completely, so I'd also drop the parameter.
> 
> The int fd is also completely useless now and can be dropped.
>
> You could even drop the call to msgready() in ccm_readmsg() entirely, as
> the readmsg(,0) (a non-blocking call) will return NULL already if there
> is no message pending.

That's right and makes perfect sense to me. I've changed CVS head
(ccm.c 1.34, 1.35) according to it. Thanks!

-yi

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
[prev in list] [next in list] [prev in thread] [next in thread]