[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ha-dev
Subject:    [Linux-ha-dev] Re: heartbeat hb_api.c:find_client
From:       Alan Robertson <alanr () unix ! sh>
Date:       2003-07-17 17:12:10
[Download RAW message or body]

Hi Hiroto,

I forgot to CC this email to the linux-ha-dev mailing list.

Hiroto Shibuya wrote:
 > Mr. Robertson,
 >
 > In hb_api.c, find_client is defined as:
 >
 > find_client(const char * fromid, const char * cpid)
 >
 > But in api_remove_client_pid, it is invoked as:
 >
 >        if ((client = find_client(cpid, NULL)) == NULL) {
 >
 > Shouldn't this be:
 >
 >        if ((client = find_client(NULL, cpid)) == NULL) {
 >
 > After my hb client application crashed, I keep on seeing log:
 >
 > heartbeat: 2003/07/17_12:06:55 info: api_audit_clients: client 2167 died
 > heartbeat: 2003/07/17_12:06:55 info: api_audit_clients: client 2061 died
 > heartbeat: 2003/07/17_12:07:05 info: api_audit_clients: client 2167 died
 > heartbeat: 2003/07/17_12:07:05 info: api_audit_clients: client 2061 died
 > heartbeat: 2003/07/17_12:07:15 info: api_audit_clients: client 2167 died
 > heartbeat: 2003/07/17_12:07:15 info: api_audit_clients: client 2061 died
 > heartbeat: 2003/07/17_12:07:25 info: api_audit_clients: client 2167 died
 >
 > because api_remove_client_pid is never able to remove client off the
 > list due to this.
 >
 > Also by inspection, api_add_client(struct ha_msg* msg) is also
 > invoking find_client as:
 >
 >         client = find_client(cpid, fromid);
 >
 > Isn't this also:
 >
 >         client = find_client(fromid, cpid);
 >
 > There seems no change regarding this between 1.1.1 and 1.1.2.

It sounds like you're right.  Want to patch it, verify the patch, and send
it to the list?

	Thanks!

	-- Alan Robertson
	   alanr@unix.sh


-- 
      Alan Robertson <alanr@unix.sh>

"Openness is the foundation and preservative of friendship...  Let me claim
from you at all times your undisguised opinions." - William Wilberforce


_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.community.tummy.com
http://lists.community.tummy.com/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
[prev in list] [next in list] [prev in thread] [next in thread]