[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ha-dev
Subject:    Re: [Linux-ha-dev] [PATCH] baytech.c
From:       Alan Robertson <alanr () unix ! sh>
Date:       2002-10-31 14:32:43
[Download RAW message or body]

Kevin Dwyer wrote:
> Happened to be poking around the stonith modules to learn how it's done
> and this looked peculiar to me.  In baytech_destroy() we see:
> 
>        if (bt->rdfd >= 0) {
>                bt->rdfd = -1;
>                close(bt->rdfd);
>        }
> 
> ... which was probably simply transposed, unless you really did want to
> close the -1 file descriptor.

Hey...

If I didn't close the -1 file descriptor, then who would?

I mean nobody *else* closed it, so it seemed like maybe I should ;-)



I applied your patch to CVS.

	-- Alan Robertson
	   alanr@unix.sh

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.community.tummy.com
http://lists.community.tummy.com/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
[prev in list] [next in list] [prev in thread] [next in thread]