[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ha-dev
Subject:    Re: [Linux-ha-dev] potential bug in client_lib.c?
From:       Alan Robertson <alanr () unix ! sh>
Date:       2002-10-23 4:32:14
[Download RAW message or body]

Alan Robertson wrote:
> Zou, Yixiong wrote:
> 
>> In client_lib.c, function get_iflist(llc_private_t* pi, const char 
>> *host), inside the while loop, around line 732, the strcmp(result, 
>> API_OK) happens after ZAPMSG(reply).
>> If I read it correctly, after ZAPMSG, "reply" is gone, and so is the 
>> pointer
>> to "result". The "strcmp(result, API_OK)" would yield a undefined result.
>> I am submitting a patch for this. Someone let me know if this is correct. 
> 
> 
> Looks right to me...  It was pretty obviously broken.  Probably my 
> mistake.  Probably didn't look at the return code in the test program...

Forgot to mention... I committed your change.

	-- Alan Robertson
	   alanr@unix.sh

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.community.tummy.com
http://lists.community.tummy.com/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
[prev in list] [next in list] [prev in thread] [next in thread]