[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ha-dev
Subject:    Re: [Linux-ha-dev] Possible memory leaks..
From:       Alan Robertson <alanr () unix ! sh>
Date:       2002-04-30 23:48:47
[Download RAW message or body]

Kevin Dwyer wrote:

> I was trying to sift out exactly what messages sent to the API do and I
> believe  I found a few possible memory leaks in hb_api.c.  It starts at
> line 582 where there is a return, but it doesn't appear that the "resp"
> msg has been deleted.  The block should probably read:
> 
>         if ((client = find_client(fromid, pid)) == NULL) {
>                 ha_log(LOG_ERR, "api_process_request: msg from non-client");
> 		ha_msg_del(resp); resp=NULL;
>                 return;
>         }
> 
> And the same is true for the next if block.  As I said, I wasn't looking
> for them so I haven't checked for others.  These instances just happened
> to stand out.  It's also not too critical because they only happen when
> there is an error anyway, but you wouldn't want to give somebody the
> chance to do that.


Good catch!

What version did you find this in?

Never mind!  Looks lclaudio already incorporated your fix!

	Good going guys!

	-- Alan Robertson
	   alanr@unix.sh





_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.community.tummy.com
http://lists.community.tummy.com/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
[prev in list] [next in list] [prev in thread] [next in thread]