[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-gpio
Subject:    Re: [PATCH v4 2/2] pinctrl: qcom: Add SDX75 pincontrol driver
From:       Rohit Agarwal <quic_rohiagar () quicinc ! com>
Date:       2023-04-27 11:19:11
Message-ID: ca738971-036b-f180-88f7-cefe0ed5a412 () quicinc ! com
[Download RAW message or body]


On 4/27/2023 4:24 PM, Andy Shevchenko wrote:
> On Thu, Apr 27, 2023 at 11:53 AM Rohit Agarwal
> <quic_rohiagar@quicinc.com> wrote:
> > On 4/26/2023 10:12 PM, Andy Shevchenko wrote:
> > > On Wed, Apr 26, 2023 at 6:18 PM Rohit Agarwal <quic_rohiagar@quicinc.com> \
> > > wrote:
> > > > On 4/26/2023 8:34 PM, andy.shevchenko@gmail.com wrote:
> ...
> 
> > > > Ok, Will update this. Shall I also update "PINGROUP" to "PINCTRL_PINGROUP"?
> > > Yes, please.
> > PINCTRL_PINGROUP cannot be used as it is, since msm_pigroup has multiple
> > other fields that needs to be set
> > for each pingroup defined.
> > Would rename this to SDX75_PINGROUP, as seen on some other platforms.
> > Would that be ok?
> For this patch, yes. But can you create a separate followup that
> replaces three members of struct msm_pingroup by embedding struct
> pingroup into it? There are examples of such changes in the kernel
> already. https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/drivers/pinctrl?id=39b707fa7aba7cbfd7d53be50b6098e620f7a6d4
>  
Sure, create a separate followup patch referring it. Will use 
SDX75_PINGROUP for now.
Thanks,
Rohit.


[prev in list] [next in list] [prev in thread] [next in thread]