[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-gpio
Subject:    Re: Question regarding runtime pinctrl (2nd try)
From:       Andy Shevchenko <andriy.shevchenko () intel ! com>
Date:       2022-11-30 15:43:54
Message-ID: Y4d6OosnHIDB2h6s () smile ! fi ! intel ! com
[Download RAW message or body]

On Wed, Nov 30, 2022 at 03:09:50PM +0000, Niedermayr, BENEDIKT wrote:
> Hello,
> 
> I got no response since last time so I try it again, but with a bit more
> knowledge this time.
> 
> After carefully reading the pinctrl documentation
> (driver-api/pin-control.rst) it was very clear for me that such an interface
> already exists and is accessable via debugfs. The documentation is very clear
> and self-explanatory. Thanks for that!
> At the time of writing my last email [1] I took a look into an older BSP
> kernel where this feature has not been implemented, yet. I must apologize for
> that...
> 
> Now my last concern is using debugfs on a productive system. IMHO debugfs is
> not the right interface to interact on a productive system.

And this is a point. No-one should try it on the production systems.

> Especially when
> when a unprivileged process wants to interact with an interface offered by
> debugfs. It's possible to change
> permissions on files and folders there but nevertheless I think that this is
> not the way to go, since debugfs was designed to offer interfaces to
> privileged processes only.

Correct.

> My proposal would be to implement an chardev interface for that and using
> udev rules to assign correct permissions to that. With this interface I can
> then select the active pinctrl-groups which have been defined in the device
> tree before.
> I could also imagine to put the interface into the sysfs (that would be very
> close to the debugfs implementation I think).
> 
> What do you think about it? Am I still missing something?

In my opinion -- no go.

The platform description (ACPI, DT, or board files) should know what they are
doing. If something missing to achieve what you need via existing interfaces
we rather think about that, but no, the debugfs stays and only for the purposes
of development on the "I know what I'm doing" basis.

> [1] https://marc.info/?l=linux-gpio&m=166850640920120

-- 
With Best Regards,
Andy Shevchenko


[prev in list] [next in list] [prev in thread] [next in thread]