[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-gpio
Subject:    Re: [PATCH] pinctrl: sunrisepoint: Align GPIO number space with Windows
From:       Hans de Goede <hdegoede () redhat ! com>
Date:       2018-04-30 15:18:15
Message-ID: 7abb7f67-2c58-4431-69ae-a8ac381e31d6 () redhat ! com
[Download RAW message or body]

Hi,

On 30-04-18 15:30, Mika Westerberg wrote:
> On Mon, Apr 30, 2018 at 02:51:34PM +0200, Linus Walleij wrote:
>> On Thu, Mar 29, 2018 at 4:37 PM, Mika Westerberg
>> <mika.westerberg@linux.intel.com> wrote:
>>
>>> It turns out that the Windows GPIO driver for Sunrisepoint PCH-H uses
>>> similar bank structure than it does for Cannon Lake with the exception
>>> that here the bank size is always 24 pins. Starting from pad group E the
>>> BIOS/Windows GPIO numbering does not match the hardware anymore but
>>> instead there are gaps to make each pad group ("bank") consume exactly
>>> 24 pins. Because of this Linux does not use correct pins for
>>> GpioIo/GpioIo resources exposed by the BIOS.
>>>
>>> This patch aligns the GPIO number space with BIOS/Windows to make sure
>>> the same numbering scheme is used in Linux as well following what we did
>>> already for Intel Cannon Lake.
>>>
>>> Link: https://bugzilla.redhat.com/show_bug.cgi?id=1543769
>>> Reported-by: Vivien FRASCA <vivien.frasca@gmail.com>
>>> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>>
>> Patch applied to my "devel" branch for now.
>>
>> I figured out it should not go into stable.
> 
> Right, it depends on so many other commits which not all can be
> considerd stable material.
> 
>> But should it rather go to fixes for v4.17-rc:s?
> 
> I would prefer v4.17-rcX if possible.

Yes this fixes the touchpad not working on various Asus models,
so v4.17-rcX would definitely be good.

Thanks & Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]