[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-gpio
Subject:    Re: pinctrl/amd: Configure GPIO register using BIOS settings
From:       Dmitry Torokhov <dmitry.torokhov () gmail ! com>
Date:       2017-09-28 17:07:12
Message-ID: CAKdAkRTb-aKQOOdSpx0iR0+KjdcBRz__Byyybu-QbSxLSRYVVA () mail ! gmail ! com
[Download RAW message or body]

Hi Nitesh,

On Thu, Sep 28, 2017 at 12:46 AM, Agrawal, Nitesh-kumar
<Nitesh-kumar.Agrawal@amd.com> wrote:
> -----Original Message-----
> From: Dmitry Torokhov [mailto:dmitry.torokhov@gmail.com]
> Sent: Thursday, September 28, 2017 12:28 PM
> To: Agrawal, Nitesh-kumar <Nitesh-kumar.Agrawal@amd.com>
> Cc: linus.walleij@linaro.org; Sen, Pankaj <Pankaj.Sen@amd.com>; S-k, Shyam-sundar \
>                 <Shyam-sundar.S-k@amd.com>; linux-gpio@vger.kernel.org
> Subject: Re: pinctrl/amd: Configure GPIO register using BIOS settings
> 
> On Fri, Sep 09, 2016 at 03:18:09PM +0000, Agrawal, Nitesh-kumar wrote:
> > In the function amd_gpio_irq_set_type, use the settings provided by
> > the BIOS,when the LevelTrig is Edge and activeLevel is HIGH, to
> > configure the GPIO registers. Ignore the settings from client.
> > 
> > Reviewed-by: Pankaj Sen <Pankaj.Sen@amd.com>
> > Signed-off-by: Nitesh Kumar Agrawal <Nitesh-kumar.Agrawal@amd.com>
> 
> Just found this patch in the tree. Can you please explain why it is needed (the \
> patch description unfortunately tells what the patch does, but not why). 
> I would expect that we either allow reprogramming the trigger as client wishes or \
> would error out and let the upper layers know. Silently "fixing" the settings is \
> wrong course of action in my opinion. 
> If this was trying to work around Elan touchpad drivers not working on AMD \
> platforms it needs to be solved in Elan driver, not here. 
> [Nitesh]We have reverted the patch in the later version of the patch.
> 

Where was it reverted? I am looking at today's linux-next, and I am
still seeing this comment in pinctrl-amd.c:

        /* Ignore the settings coming from the client and
        * read the values from the ACPI tables
        * while setting the trigger type
        */

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[prev in list] [next in list] [prev in thread] [next in thread]