[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-fsdevel
Subject:    Re: [PATCH 0/2] overlayfs fixes
From:       Andy Whitcroft <apw () canonical ! com>
Date:       2010-11-28 19:18:14
Message-ID: 20101128191813.GC11339 () shadowen ! org
[Download RAW message or body]

On Thu, Nov 25, 2010 at 04:06:55PM +0100, Miklos Szeredi wrote:
> On Wed, 17 Nov 2010, Andy Whitcroft wrote:
> >   overlayfs: handle missing lower inodes in ovl_is_same_inode
> 
> I don't see how this could be needed.  vfs_is_same_inode() checks if
> the dentries are positive.  In that case either the upper dentry or
> the lower dentry or both must exist.

It was cirtinaly exploding in my tests without that change.  The test
case was overlaying a tmpfs over a squashfs.

> >   overlayfs: ovl_copy_up_xattr -- handle EOPNOTSUPP from vfs_listxattr
> 
> Applied.  Thanks, Andy.
> 
> I pushed an updated version based on v2.6.37-rc3 to the overlayfs.v5
> branch:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs.v5
> 
> Thanks,
> Miklos

I'll retest with that version and see if the first patch is still
required.

Thanks for the updated version.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]