[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-fsdevel
Subject:    Re: [PATCH 19/19] BLOCK: Make it possible to disable the block
From:       Andrew Morton <akpm () osdl ! org>
Date:       2006-08-30 21:20:45
Message-ID: 20060830142045.c87f341e.akpm () osdl ! org
[Download RAW message or body]

On Wed, 30 Aug 2006 17:06:39 -0400
Trond Myklebust <trond.myklebust@fys.uio.no> wrote:

> > This function is misnamed and is implemented in the wrong place.  It's not
> > really a block thing at all.  If/when/soon NFS starts to implement it and
> > call it, things will need to be renamed and reshuffled.
> 
> Already done in the NFS git tree. See attached patch.

Right, I saw that, didn't know that you'd merged it yet.  Ho hum, yet
another reject to fix up.

I think your patch is a bit minimal: at adds blk_congestion_end() whereas
it'd make better sense longer-term to remove blk_congestion_wait() and
blk_congestion_end() altogether, replace them with something which is
somewhere else and which doesn't mention "blk".  I expected this to be done
four years ago ;)

But not now.  Nobody's allowed to touch anything else!
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]