[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-fsdevel
Subject:    Re: [PATCH] Introduce BSD-style user credential [3/3]
From:       Daniel Phillips <phillips () arcor ! de>
Date:       2002-09-01 15:23:57
[Download RAW message or body]

On Saturday 31 August 2002 18:30, Trond Myklebust wrote:
> >>>>> " " == Linus Torvalds <torvalds@transmeta.com> writes:
> 
>      > One thing that may be interesting (I certainly think it migth
>      > be), would be to add a "struct user_struct *" pointer to the
>      > vfs_cred as well. This is because I'd just _love_ to have that
>      > "user_struct" fed down to the VFS layer, since I think that is
>      > where we may some day want to put things like user-supplied
>      > cryptographic keys etc.
> 
>      > The advantage of "struct user_struct" (as opposed to just a
>      > uid_t) is that it can have information that lives for the whole
>      > duration of a login, and it's really the only kind of data
>      > structure in the kernel that can track that kind of
>      > information.
> 
> No problem at all with this. Indeed I agree it makes a lot of sense...
> 
> The only thing is if you'd allow me to do it as an incremental patch
> to the initial one?
> I don't see 'struct user_struct *' as replacing the existing 'uid'
> entry, so there should be no need to change the existing API. Instead,
> we can just add in the necessary call to alloc_uid() to
> vfscred_create() and/or setfsuid()...

I really do like Kai's name suggestion 'struct session'.

-- 
Daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]