[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-fpga
Subject:    Re: [RFC PATCH 1/2] fpga: region: fix kernel-doc
From:       Xu Yilun <yilun.xu () intel ! com>
Date:       2023-07-10 8:05:30
Message-ID: ZKu7yj1+QumQ9DlM () yilunxu-OptiPlex-7050
[Download RAW message or body]

On 2023-07-06 at 14:30:34 -0700, Randy Dunlap wrote:
> Hi--
> 
> On 7/6/23 07:27, Marco Pagani wrote:
> > - Fix the following warnings issued by the kernel-doc script:
> > 
> > drivers/fpga/fpga-region.c:46: warning: No description found for return value of \
> > 'fpga_region_get' drivers/fpga/fpga-region.c:97: warning: No description found \
> > for return value of 'fpga_region_program_fpga' drivers/fpga/fpga-region.c:295: \
> > warning: No description found for return value of 'fpga_region_init' 
> > - Remove the "and registers a reconfig notifier" part from the description
> > of fpga_region_init() since it does not register an of_overlay notifier
> > anymore.
> > 
> > - Remove the outdated "if @np is not an FPGA Region" case from the return
> > description of fpga_region_get() and replace it with the case when
> > try_module_get() fails.
> > 
> > Signed-off-by: Marco Pagani <marpagan@redhat.com>
> 
> Looks good. Thanks.
> 
> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Acked-by: Xu Yilun <yilun.xu@intel.com>

Applied.

BTW: No need to have RFC if you think it is ready for full review.


[prev in list] [next in list] [prev in thread] [next in thread]