[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-fpga
Subject:    Re: [PATCH] fpga: stratix10-soc: Do not use ret uninitialized in s10_probe()
From:       Russ Weight <russell.h.weight () intel ! com>
Date:       2021-11-29 19:24:26
Message-ID: 41939d45-76ef-e59f-135f-b5c05cd4f5e5 () intel ! com
[Download RAW message or body]

Reviewed-by: Russ Weight <russell.h.weight@intel.com>

Thanks,
- Russ

On 11/29/21 8:10 AM, Nathan Chancellor wrote:
> Clang warns:
> 
> drivers/fpga/stratix10-soc.c:431:9: warning: variable 'ret' is uninitialized when \
> used here [-Wuninitialized] return ret;
> ^~~
> drivers/fpga/stratix10-soc.c:402:9: note: initialize the variable 'ret' to silence \
> this warning int ret;
> ^
> = 0
> 1 warning generated.
> 
> ret is only assigned in an error path now so just return 0 directly.
> 
> Fixes: 4ba0b2c294fe ("fpga: mgr: Use standard dev_release for class driver")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1517
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/fpga/stratix10-soc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
> index 737d14c6e0de..357cea58ec98 100644
> --- a/drivers/fpga/stratix10-soc.c
> +++ b/drivers/fpga/stratix10-soc.c
> @@ -428,7 +428,7 @@ static int s10_probe(struct platform_device *pdev)
> 	}
> 
> 	platform_set_drvdata(pdev, mgr);
> -	return ret;
> +	return 0;
> 
> probe_err:
> 	stratix10_svc_free_channel(priv->chan);
> 
> base-commit: 8886a579744fbfa53e69aa453ed10ae3b1f9abac


[prev in list] [next in list] [prev in thread] [next in thread]