[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-fpga
Subject:    Re: [PATCH V3 XRT Alveo 03/18] fpga: xrt: xclbin file helper functions
From:       Tom Rix <trix () redhat ! com>
Date:       2021-02-28 16:54:29
Message-ID: c79176af-8d0c-2300-3e4a-dfa604f10a62 () redhat ! com
[Download RAW message or body]


On 2/26/21 1:23 PM, Lizhi Hou wrote:
> Hi Tom,
> 
> 
snip

> > 
> > I also do not see a pragma pack, usually this is set of 1 so the compiler does \
> > not shuffle elements, increase size etc.
> This data structure is shared with other tools. And the structure is well defined \
> with reasonable alignment. It is compatible with all compilers we have tested. So \
> pragma pack is not necessary.

You can not have possibly tested all the configurations since the kernel supports \
many arches and compilers.

If the tested existing alignment is ok, pragma pack should be a noop on your tested \
configurations.

And help cover the untested configurations.

Tom


[prev in list] [next in list] [prev in thread] [next in thread]