[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-fpga
Subject:    Re: [PATCH v2] MAINTAINERS: Add FPGA SUBDEVICES
From:       Tom Rix <trix () redhat ! com>
Date:       2021-01-23 15:01:24
Message-ID: 96a9d3d9-6091-47c9-21f9-0cfdd9464732 () redhat ! com
[Download RAW message or body]


On 1/22/21 3:52 PM, Moritz Fischer wrote:
> On Fri, Jan 22, 2021 at 11:29:28AM -0800, trix@redhat.com wrote:
> > From: Tom Rix <trix@redhat.com>
> > 
> > Every FPGA has several subdevices in other subsystems.
> > The new FPGA subdevices section is necessary to ensure changes to
> > the subdevices files get reviewed within the context of the FPGA
> > subsystem.
> > 
> > Signed-off-by: Tom Rix <trix@redhat.com>
> > ---
> > v1: Add several more subdevices
> > ---
> > MAINTAINERS | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 17ac5bdce521..96d6f00b0584 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -6975,6 +6975,17 @@ F:	drivers/fpga/
> > F:	include/linux/fpga/
> > F:	tools/testing/selftests/drivers/fpga/
> > 
> > +FPGA SUBDEVICES
> > +R:	Tom Rix <trix@redhat.com>
> > +L:	linux-fpga@vger.kernel.org
> > +S:	Maintained
> > +F:	Documentation/ABI/testing/sysfs-driver-intel-m10-bmc
> > +F:	Documentation/hwmon/intel-m10-bmc-hwmon.rst
> > +F:	drivers/hwmon/intel-m10-bmc-hwmon.c
> > +F:	drivers/memory/dfl-emif.c
> > +F:	drivers/mfd/intel-m10-bmc.c
> > +F:	include/linux/mfd/intel-m10-bmc.h
> > +
> > FPU EMULATOR
> > M:	Bill Metzenthen <billm@melbpc.org.au>
> > S:	Maintained
> > -- 
> > 2.27.0
> > 
> All these subsystems have maintainers, I think that's up to them.
> Ideally each of those drivers behaves like a normal device in the
> corresponding subsystem and the way it's implemented doesn't matter.
> 
> Plenty of other examples for that
> 
> drivers/net/ethernet/xilinx/*

This device has a specific maintainer, the files listed above to do not.

So any review or maintenance falls to the subsystem maintainer who likely is not be \
aware of it fitting within an fpga card.  They certainly will not have the hardware \
to test if the changes effect the card.

So until they have specific maintainers, I would like to help fill that gap by making \
sure they at least have a review.  Sending the changes to the linux-fpga mailing list \
will allow others interested in their specific fpga card to also weigh in.

The specific reason for doing this now is several in-flight changes are being made to

include/linux/mfd/intel-m10-bmc.h

That effected a couple of fpga subdevices and conflicted with Russ' security manager \
patchset.  To help resolve the conflict I had to track down all the in flight \
changes.  If I had been on the reviewer list for the file or the patch had been \
mirrored to linux-fpga, I would have been notified of the changes earlier and finding \
the conflict would have not been as difficult.

Since we are pushing subdevices to the subsystem, I think we should also be \
encouraging subdevices to be maintained by the submitter and if they are not, they \
get added to the subdevices list so all the work is not done by the subsystem \
maintainers.

Tom

> 
> for example.
> 
> - Moritz
> 


[prev in list] [next in list] [prev in thread] [next in thread]