[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-fpga
Subject:    Re: [PATCH v13 0/6] add DFL bus support to MODULE_DEVICE_TABLE()
From:       Xu Yilun <yilun.xu () intel ! com>
Date:       2020-11-23 2:29:47
Message-ID: 20201123022947.GC12837 () yilunxu-OptiPlex-7050
[Download RAW message or body]

Hi Moritz:

Do you have some suggestion on this patchset? In last pull request,
there are some comments, I explained for them and fixes some of them.
I'm wondering if they are ready now.

Thanks in advance,
Yilun

On Thu, Nov 12, 2020 at 01:42:33PM +0800, Xu Yilun wrote:
> Main changes from v1: 
> - A new patch (Patch #3) to fix the description.
> - Rename the dfl-bus.h to dfl.h
> - Updated the MAINTAINERS under FPGA DFL DRIVERS.
> - Improve comments and minor fixes.
> 
> Main changes from v2: 
> - Change the bus name from "dfl" to "fpga-dfl", also rename related
> variables, functions ... 
> - Changes the data type of fpga_dfl_device_id.type from u8 to u16 
> - Explicitly defines the values of enum fpga_dfl_id_type
> - Delete the comments for the valid bits of type & feature_id
> - changes MODALIAS format for fpga dfl devices
> 
> Main changes from v3: 
> - Change the bus name back to "dfl".
> - Add 2 patches (#5, 6) for dfl drivers.
> - Delete the retimer FEC mode configuration via module_parameter for 
> Patch #5
> - Merge the patch "Make m10_n3000_info static" \
> (https://lore.kernel.org/linux-fpga/52d8411e-13d8-1e91-756d-131802f5f445@huawei.com/T/#t)
>  into Patch #5
> - Add static prefix for emif attributes macro for Patch #6
> 
> Main changes from v9:
> - Add the description for struct dfl_device_id in mod_devicetable.h
> - Move the dfl.h from include/linux/fpga to include/linux
> - some code refactor and minor fixes for dfl-n3000-nios
> 
> Main changes from v10:
> - use sysfs_emit instead of sprintf for both patches
> - rebase to 5.10-rc1
> 
> Main changes from v11:
> - Fix the type of driver_data from unsigned long to kernel_ulong_t
> - Fixed up header guards to match filename by Moritz
> - move the MODULE_DEVICE_TABLE() right after its definition
> 
> Main changes from v12:
> - For patch #5, fix the wrong use of logical'||', should use '|'
> 
> Xu Yilun (6):
> fpga: dfl: fix the definitions of type & feature_id for dfl devices
> fpga: dfl: move dfl_device_id to mod_devicetable.h
> fpga: dfl: add dfl bus support to MODULE_DEVICE_TABLE()
> fpga: dfl: move dfl bus related APIs to include/linux/dfl.h
> fpga: dfl: add support for N3000 Nios private feature
> memory: dfl-emif: add the DFL EMIF private feature driver
> 
> .../ABI/testing/sysfs-bus-dfl-devices-emif         |  25 +
> .../ABI/testing/sysfs-bus-dfl-devices-n3000-nios   |  47 ++
> MAINTAINERS                                        |   3 +-
> drivers/fpga/Kconfig                               |  11 +
> drivers/fpga/Makefile                              |   2 +
> drivers/fpga/dfl-n3000-nios.c                      | 588 +++++++++++++++++++++
> drivers/fpga/dfl.c                                 |   4 +-
> drivers/fpga/dfl.h                                 |  85 +--
> drivers/memory/Kconfig                             |   9 +
> drivers/memory/Makefile                            |   2 +
> drivers/memory/dfl-emif.c                          | 207 ++++++++
> include/linux/dfl.h                                |  86 +++
> include/linux/mod_devicetable.h                    |  24 +
> scripts/mod/devicetable-offsets.c                  |   4 +
> scripts/mod/file2alias.c                           |  13 +
> 15 files changed, 1023 insertions(+), 87 deletions(-)
> create mode 100644 Documentation/ABI/testing/sysfs-bus-dfl-devices-emif
> create mode 100644 Documentation/ABI/testing/sysfs-bus-dfl-devices-n3000-nios
> create mode 100644 drivers/fpga/dfl-n3000-nios.c
> create mode 100644 drivers/memory/dfl-emif.c
> create mode 100644 include/linux/dfl.h
> 
> -- 
> 2.7.4


[prev in list] [next in list] [prev in thread] [next in thread]