[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-fpga
Subject:    Re: [PATCH] fpga: remove redundant dev_err message
From:       Moritz Fischer <mdf () kernel ! org>
Date:       2020-01-03 4:59:03
Message-ID: 20200103045903.GA21472 () epycbox ! lan
[Download RAW message or body]

On Tue, Sep 10, 2019 at 05:26:56PM +0800, Ding Xiang wrote:
> devm_ioremap_resource already contains error message, so remove
> the redundant dev_err message
> 
> Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
> ---
>  drivers/fpga/ts73xx-fpga.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/fpga/ts73xx-fpga.c b/drivers/fpga/ts73xx-fpga.c
> index 9a17fe9..2888ff0 100644
> --- a/drivers/fpga/ts73xx-fpga.c
> +++ b/drivers/fpga/ts73xx-fpga.c
> @@ -119,10 +119,8 @@ static int ts73xx_fpga_probe(struct platform_device *pdev)
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	priv->io_base = devm_ioremap_resource(kdev, res);
> -	if (IS_ERR(priv->io_base)) {
> -		dev_err(kdev, "unable to remap registers\n");
> +	if (IS_ERR(priv->io_base))
>  		return PTR_ERR(priv->io_base);
> -	}
>  
>  	mgr = devm_fpga_mgr_create(kdev, "TS-73xx FPGA Manager",
>  				   &ts73xx_fpga_ops, priv);
> -- 
> 1.9.1
> 
> 
> 

Applied to for-next.

Thanks,
Moritz
[prev in list] [next in list] [prev in thread] [next in thread]