Quoting Russell King - ARM Linux : > On Thu, May 28, 2009 at 11:20:48AM -0700, Tony Lindgren wrote: >> * Andrew de Quincey [090525 09:41]: >> > Quoting Andrew de Quincey : >> > >> >> Quoting Russell King - ARM Linux : >> >> >> >>> On Tue, May 19, 2009 at 04:37:32PM -0700, Tony Lindgren wrote: >> >>>> Make 770 LCD work by passing the clock from platform data. >> >>>> Also remove the old unused functions. >> >>> >> >>> I don't like this - because its passing struct clk's through platform >> >>> data. That's not how things are supposed to work. >> >>> >> >>> The way PXA solves this problem is to have clock aliases - see >> >>> clk_add_alias(). >> >> >> >> Interesting idea - I now have a prototype patch implementing this, >> >> which I'll send when I get home (otherwise it would be an "it >> >> compiles" "test" :) >> >> >> >> There isn't a common definition of clk_add_alias() though - that >> >> symbol is defined in arch/arm/mach-pxa/clock.c, so I had to copy it >> >> into arch/arm/plat-omap/clock.c >> > >> > Attached is a patch implementing this method. I don't like the >> > duplication of the clk_alias code, but I imagine that could be resolved >> > if this method was chosen.... >> >> Andrew, can you please reply with your Signed-off-by? > > Actually, I'm very tempted to suggest that clk_add_alias() should go > into arch/arm/common/clkdev.c if we're going to have more people use it. Cool! Out of interest, what is the best practice way to pass platform specific GPIOs around? There are a number of other n770 related drivers I'm intending on cleaning up, several of which have GPIO numbers hardcoded in them. Should these be passed in platform structures, or is there something analogous to the clk_alias for GPIOs? ------------------------------------------------------------------------------ Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT is a gathering of tech-side developers & brand creativity professionals. Meet the minds behind Google Creative Lab, Visual Complexity, Processing, & iPhoneDevCamp as they present alongside digital heavyweights like Barbarian Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com _______________________________________________ Linux-fbdev-devel mailing list Linux-fbdev-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel