[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-fbdev-devel
Subject:    Re: [Linux-fbdev-devel] [PATCH 13/13] viafb: via_utility.c,
From:       Alan Cox <alan () lxorguk ! ukuu ! org ! uk>
Date:       2008-06-30 9:44:07
Message-ID: 20080630104407.6adf59ab () lxorguk ! ukuu ! org ! uk
[Download RAW message or body]

> +void get_gamma_table(unsigned int *gamma_table)

Still more globals with names asking to cause clashes

> +{
> +	unsigned char color_r[256];
> +	unsigned char color_g[256];
> +	unsigned char color_b[256];
> +	unsigned char sr1a = 0;

and possibly excesive stack usage


I think at this point however the code is in a state where it would be
more productive to merge it and then fix up the remaining smaller details
than keep going round back to VIA to change it internally and return.

So

Acked-by: Alan Cox <alan@redhat.com>  - for the patch series, subject to
further tidyups getting done after it is all merged.

Alan

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Linux-fbdev-devel mailing list
Linux-fbdev-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel
[prev in list] [next in list] [prev in thread] [next in thread]