[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-fbdev
Subject: Re: [PATCH v2 05/19] fbdev/au1200fb: Use struct fb_info.screen_buffer
From: Javier Martinez Canillas <javierm () redhat ! com>
Date: 2023-04-28 14:27:08
Message-ID: 877ctwgk03.fsf () minerva ! mail-host-address-is-not-set
[Download RAW message or body]
Thomas Zimmermann <tzimmermann@suse.de> writes:
> Use info->screen_buffer when reading and writing framebuffers in
> system memory. It's the correct pointer for this address space.
>
> The struct fb_info has a union to store the framebuffer memory. This can
> either be info->screen_base if the framebuffer is stored in I/O memory,
> or info->screen_buffer if the framebuffer is stored in system memory.
>
> As the driver operates on the latter address space, it is wrong to use
> .screen_base and .screen_buffer must be used instead. This also gets
> rid of casting needed due to not using the correct data type.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic