[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-fbdev
Subject:    Re: [PATCH] mx3fb: Fix print format string
From:       Tomi Valkeinen <tomi.valkeinen () ti ! com>
Date:       2016-08-30 8:57:43
Message-ID: fac6d05d-02d8-d5df-109f-f572ed15a0e5 () ti ! com
[Download RAW message or body]

[Attachment #2 (multipart/mixed)]


On 27/08/16 06:05, Oleg Drokin wrote:
> %ul was probably meant as %lu since the former would print
> an unsigned value and a letter l.
> 
> But in fact the whole value we are printing in u32 anyway, so
> we don't need the format to be long. Therefore just drop the l
> altogether.
> 
> Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
> ---
> Also do we really need 1000UL specification if we
> cast to u32 anyway? Or should we drop away the cast instead?
> Are pixelclocks over 4GHz possible here?
> 
>  drivers/video/fbdev/mx3fb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/mx3fb.c b/drivers/video/fbdev/mx3fb.c
> index f91b1db..8778e01 100644
> --- a/drivers/video/fbdev/mx3fb.c
> +++ b/drivers/video/fbdev/mx3fb.c
> @@ -845,7 +845,7 @@ static int __set_par(struct fb_info *fbi, bool lock)
>  		if (fbi->var.sync & FB_SYNC_SHARP_MODE)
>  			mode = IPU_PANEL_SHARP_TFT;
>  
> -		dev_dbg(fbi->device, "pixclock = %ul Hz\n",
> +		dev_dbg(fbi->device, "pixclock = %u Hz\n",
>  			(u32) (PICOS2KHZ(fbi->var.pixclock) * 1000UL));
>  
>  		if (sdc_init_panel(mx3fb, mode,
> 

Thanks, queued for 4.9.

 Tomi


["signature.asc" (application/pgp-signature)]
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[prev in list] [next in list] [prev in thread] [next in thread]