[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-ext4
Subject: Re: [PATCH v2 3/4] f2fs: add inline encryption support
From: Eric Biggers <ebiggers () kernel ! org>
Date: 2020-06-29 18:53:20
Message-ID: 20200629185320.GH20492 () sol ! localdomain
[Download RAW message or body]
On Mon, Jun 29, 2020 at 12:04:04PM +0000, Satya Tangirala via Linux-f2fs-devel wrote:
> Wire up f2fs to support inline encryption via the helper functions which
> fs/crypto/ now provides. This includes:
>
> - Adding a mount option 'inlinecrypt' which enables inline encryption
> on encrypted files where it can be used.
>
> - Setting the bio_crypt_ctx on bios that will be submitted to an
> inline-encrypted file.
>
> - Not adding logically discontiguous data to bios that will be submitted
> to an inline-encrypted file.
>
> - Not doing filesystem-layer crypto on inline-encrypted files.
>
> This patch includes a fix for a race during IPU by
> Sahitya Tummala <stummala@codeaurora.org>
>
> Co-developed-by: Eric Biggers <ebiggers@google.com>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> Signed-off-by: Satya Tangirala <satyat@google.com>
> Acked-by: Jaegeuk Kim <jaegeuk@kernel.org>
Reviewed-by: Eric Biggers <ebiggers@google.com>
> ---
> Documentation/filesystems/f2fs.rst | 7 +++
> fs/f2fs/compress.c | 2 +-
> fs/f2fs/data.c | 78 +++++++++++++++++++++++++-----
> fs/f2fs/super.c | 35 ++++++++++++++
> 4 files changed, 108 insertions(+), 14 deletions(-)
>
> diff --git a/Documentation/filesystems/f2fs.rst b/Documentation/filesystems/f2fs.rst
> index 099d45ac8d8f..8b4fac44f4e1 100644
> --- a/Documentation/filesystems/f2fs.rst
> +++ b/Documentation/filesystems/f2fs.rst
> @@ -258,6 +258,13 @@ compress_extension=%s Support adding specified extension, so that f2fs can enab
> on compression extension list and enable compression on
> these file by default rather than to enable it via ioctl.
> For other files, we can still enable compression via ioctl.
> +inlinecrypt
> + When possible, encrypt/decrypt the contents of encrypted
> + files using the blk-crypto framework rather than
> + filesystem-layer encryption. This allows the use of
> + inline encryption hardware. The on-disk format is
> + unaffected. For more details, see
> + Documentation/block/inline-encryption.rst.
> ====================== ============================================================
Last time I suggested adding "When possible, ", and it got added here but not in
the ext4 patch. It should go in both.
- Eric
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic