[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ext4
Subject:    Re: [PATCH 3/7] ext4 resize: missing brelse() in case success in add_new_gdb()
From:       Vasily Averin <vvs () virtuozzo ! com>
Date:       2018-10-30 13:45:45
Message-ID: 3a7944cb-ca99-49d1-85e8-f5371a86fba6 () virtuozzo ! com
[Download RAW message or body]

please drop this one, it isn't correct.

On 10/29/2018 06:25 PM, Vasily Averin wrote:
> Fixes ac27a0ec112a ("ext4: initial copy of files from ext3")
> #? cc: stable <stable@vger.kernel.org>     # 2.6.19 or evel earlier in ext3
> 
> Signed-off-by: Vasily Averin <vvs@openvz.org>
> ---
>  fs/ext4/resize.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
> index 0a4dc6217e78..ff17480e8613 100644
> --- a/fs/ext4/resize.c
> +++ b/fs/ext4/resize.c
> @@ -874,6 +874,7 @@ static int add_new_gdb(handle_t *handle, struct inode *inode,
>  		goto exit_inode;
>  	}
>  	brelse(dind);
> +	brelse(iloc.bh);
>  
>  	o_group_desc = EXT4_SB(sb)->s_group_desc;
>  	memcpy(n_group_desc, o_group_desc,
> 
[prev in list] [next in list] [prev in thread] [next in thread]