[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ext4
Subject:    Re: [PATCH 06/12] e2fsck: update i_blocks accounting for ea_inode feature
From:       Tahsin Erdogan <tahsin () google ! com>
Date:       2017-06-30 1:39:37
Message-ID: CAAeU0aM7MGcVkAkY5oDzGDDCdTHiARm_ykjPKbJz7Y=YnT5Xgg () mail ! gmail ! com
[Download RAW message or body]

>> This makes it all the more important that the "fast symlink" checking be
>> divorced from i_blocks, and instead depend on i_size.  Otherwise, we will
>> have yet another bunch of problems as large xattrs on a fast symlink will
>> incorrectly result in problems with the symlink.
>>
> Totally agree. The changes to i_blocks accounting for ea_inode feature
> likely broke ext4_inode_is_fast_symlink() in kernel. I will try to fix
> that first.

FYI, I sent out a patch to fix e2fsprogs part too: ("[PATCH]
e2fsprogs: add ext2fs_is_fast_symlink() function")
[prev in list] [next in list] [prev in thread] [next in thread]