[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ext4
Subject:    Re: [PATCH 15/54] e2fsck: handle multiple *ind block collisions with critical metadata
From:       Theodore Ts'o <tytso () mit ! edu>
Date:       2015-01-28 13:52:54
Message-ID: 20150128135254.GO2453 () thunk ! org
[Download RAW message or body]

On Mon, Jan 26, 2015 at 11:37:10PM -0800, Darrick J. Wong wrote:
> An earlier patch tried to detect indirect blocks that conflicted with
> critical FS metadata for the purpose of preventing corrections being
> made to those indirect blocks.  Unfortunately, that patch cannot
> handle more than one conflicting *ind block per file; therefore, use
> the ref_block parameter to test the metadata block map to decide if
> we need to avoid fixing the *ind block when we're iterating the
> block's entries.  (We have to iterate the block to capture any blocks
> that the block points to, as they could be in use.)
> 
> As a side note, in 1B we'll reallocate all those conflicting *ind
> blocks and restart fsck, so the contents will be checked eventually.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Applied, thanks.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]