[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ext4
Subject:    Re: [PATCH V2] fix type of "offset" in ext4_io_end
From:       Eric Sandeen <sandeen () redhat ! com>
Date:       2010-01-30 18:33:57
Message-ID: 4B647B95.7070206 () redhat ! com
[Download RAW message or body]

tytso@mit.edu wrote:
> On Fri, Jan 29, 2010 at 02:28:23PM -0600, Eric Sandeen wrote:
>> The "offset" member in ext4_io_end holds bytes, not
>> blocks, so ext4_lblk_t is wrong - and too small (u32)
>>
>> This caused the testcase "Possible ext4 data corruption
>> with large files and async I/O" sent by Giel to fail when it
>> wrapped around to 0.
>>
>> Also fix up the type of arguments to
>> ext4_convert_unwritten_extents(), it gets ssize_t from
>> ext4_end_aio_dio_nolock() and ext4_ext_direct_IO()
>>
>> Reported-by: Giel de Nijs <giel@vectorwise.com>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>> ---
> 
> This looks important enough (and low risk enough) to push to Linus
> before the next merge window.   Comments?
> 
> 						- Ted

yeah, I think so.

if there's any concern over the size_t type changes I could
split it up.

-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]