[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-efi
Subject:    Re: [PATCH Part1 v5 35/38] x86/sev: Register SNP guest request platform device
From:       Brijesh Singh <brijesh.singh () amd ! com>
Date:       2021-08-31 16:03:10
Message-ID: ada086eb-2a27-ff25-6db1-3d629cb31868 () amd ! com
[Download RAW message or body]

Hi Dov,


On 8/31/21 6:37 AM, Dov Murik wrote:
>> +
>> +	if (!platform_device_register(&guest_req_device))
>> +		dev_info(&guest_req_device.dev, "secret phys 0x%llx\n", snp_secrets_phys);
> 
> Should you return the error code from platform_device_register() in case
> it fails (returns something other than zero)?
> 

Yes, I will fix it in next rev. Will return a non-zero on failure to 
register the device.

thanks
[prev in list] [next in list] [prev in thread] [next in thread]