[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-efi
Subject:    Re: [PATCH Part1 v5 30/38] x86/compressed/64: store Confidential Computing blob address in bootparam
From:       Borislav Petkov <bp () alien8 ! de>
Date:       2021-08-31 10:26:28
Message-ID: YS4D1A9Uy1TmNwmT () zn ! tnic
[Download RAW message or body]

On Fri, Aug 27, 2021 at 02:09:55PM -0500, Michael Roth wrote:
> Most of the #ifdef'ery is due to the EFI scan, so I moved that part out
> to a separate helper, snp_probe_cc_blob_efi(), that lives in
> boot/compressed.sev.c. Still not pretty, but would this be acceptable?

It is still ugly... :)

I guess you should simply do two separate functions - one doing the
compressed dance and the other the later parsing and keep 'em separate.
It's not like you're duplicating a ton of code so...

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette
[prev in list] [next in list] [prev in thread] [next in thread]