[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-edac
Subject:    Re: [PATCH] rasdaemon: ARM: fully initialize ras_arm_event
From:       Mauro Carvalho Chehab <mchehab+samsung () kernel ! org>
Date:       2018-04-25 10:38:43
Message-ID: 20180425073843.2f87b084 () vento ! lan
[Download RAW message or body]

Em Fri, 2 Feb 2018 10:20:48 -0500
Aristeu Rozanski <aris@redhat.com> escreveu:

> Issue found by covscan:
> 
> 1. rasdaemon-0.4.1/ras-arm-handler.c:32: var_decl: Declaring variable "ev" without \
> initializer. 16. rasdaemon-0.4.1/ras-arm-handler.c:81: uninit_use_in_call: Using \
> uninitialized value "ev.error_count" when calling "ras_store_arm_record". 23. \
> rasdaemon-0.4.1/ras-record.c:243:2: read_parm_fld: Reading a parameter field.

Applied, thanks! It should be at version 0.6.1:
https://www.infradead.org/~mchehab/rasdaemon/rasdaemon-0.6.1.tar.bz2

> 
> Signed-off-by: Aristeu Rozanski <arozansk@redhat.com>
> 
> diff --git a/ras-arm-handler.c b/ras-arm-handler.c
> index a76470d..2f170e2 100644
> --- a/ras-arm-handler.c
> +++ b/ras-arm-handler.c
> @@ -31,6 +31,8 @@ int ras_arm_event_handler(struct trace_seq *s,
> 	struct tm *tm;
> 	struct ras_arm_event ev;
> 
> +	memset(&ev, 0, sizeof(ev));
> +
> 	/*
> 	 * Newer kernels (3.10-rc1 or upper) provide an uptime clock.
> 	 * On previous kernels, the way to properly generate an event would
> 


Thanks,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-edac" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[prev in list] [next in list] [prev in thread] [next in thread]