[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-edac
Subject: Re: [PATCH 1/4] s390: convert debug_info.ref_count from atomic_t to refcount_t
From: Peter Zijlstra <peterz () infradead ! org>
Date: 2017-02-20 13:39:14
Message-ID: 20170220133914.GQ6500 () twins ! programming ! kicks-ass ! net
[Download RAW message or body]
On Mon, Feb 20, 2017 at 02:24:24PM +0100, Heiko Carstens wrote:
> On Mon, Feb 20, 2017 at 01:06:18PM +0200, Elena Reshetova wrote:
> > @@ -361,7 +361,7 @@ debug_info_create(const char *name, int pages_per_area, int nr_areas,
> > debug_area_last = rc;
> > rc->next = NULL;
> >
> > - debug_info_get(rc);
> > + refcount_set(&rc->ref_count, 1);
>
> This is not wrong, but I will remove this hunk before applying your patch,
> since this doesn't look like an obvious correct change at first glance.
I suspect; but have not looked at the code; that this would otherwise
attempt to do a 0 -> 1 increment, which refcount_inc() will refuse (and
WARN) over.
--
To unsubscribe from this list: send the line "unsubscribe linux-edac" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic