[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-edac
Subject:    [PATCH 6/7] driver/edac/fsl_ddr: Fix kernel warning when module is removed
From:       York Sun <york.sun () nxp ! com>
Date:       2016-07-22 21:21:43
Message-ID: 1469222504-32287-6-git-send-email-york.sun () nxp ! com
[Download RAW message or body]

When compiled as a module, removing this module causes kernel
warnings when irq_dispose_mapping() is called. Instead of calling
irq_of_parse_and_map(), using platform_get_irq() to acquire the
IRQ number.

Signed-off-by: York Sun <york.sun@nxp.com>
---
 drivers/edac/fsl_ddr_edac.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/edac/fsl_ddr_edac.c b/drivers/edac/fsl_ddr_edac.c
index 363070a..0505472 100644
--- a/drivers/edac/fsl_ddr_edac.c
+++ b/drivers/edac/fsl_ddr_edac.c
@@ -563,7 +563,7 @@ static int fsl_ddr_mc_err_probe(struct platform_device *op)
 		ddr_out32(pdata->mc_vbase + MC_ERR_SBE, 0x10000);
 
 		/* register interrupts */
-		pdata->irq = irq_of_parse_and_map(op->dev.of_node, 0);
+		pdata->irq = platform_get_irq(op, 0);
 		res = devm_request_irq(&op->dev, pdata->irq,
 				       fsl_ddr_mc_isr,
 				       IRQF_SHARED,
@@ -571,7 +571,6 @@ static int fsl_ddr_mc_err_probe(struct platform_device *op)
 		if (res < 0) {
 			pr_err("%s: Unable to request irq %d for FSL_DDR DRAM ERR\n",
 			       __func__, pdata->irq);
-			irq_dispose_mapping(pdata->irq);
 			res = -ENODEV;
 			goto err2;
 		}
@@ -603,7 +602,6 @@ static int fsl_ddr_mc_err_remove(struct platform_device *op)
 
 	if (edac_op_state == EDAC_OPSTATE_INT) {
 		ddr_out32(pdata->mc_vbase + MC_ERR_INT_EN, 0);
-		irq_dispose_mapping(pdata->irq);
 	}
 
 	ddr_out32(pdata->mc_vbase + MC_ERR_DISABLE,
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-edac" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]