[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-edac
Subject:    Re: [PATCH] rasdaemon: use MCA error msg as error_msg
From:       Aristeu Rozanski <aris () redhat ! com>
Date:       2015-06-12 13:33:01
Message-ID: 20150612133301.GI14408 () redhat ! com
[Download RAW message or body]

On Fri, Jun 12, 2015 at 06:35:37PM +0900, Seiichi Ikarashi wrote:
> In the case of machine-checks which do not have a model-specific MCA error
> code but have an architectural code only, mce_event.error_msg becomes empty
> then you don't know what happened.
> 
> # ras-mc-ctl --summary
> (snip)
> MCE records summary:
> 	1  errors
>           ^
>           empty!
> 
> # ras-mc-ctl --errors
> (snip)
> MCE events:
> 1 2015-06-12 00:21:46 +0900 error: , mcg mcgstatus= 0, mci Corrected_error
>                                   ^
>                                 empty!
> 
> Error_enabled, mcgcap=0x07000c16, status=0x9c0000000000017a, addr=0x204fffffff,
> misc=0x4004000000000080, walltime=0x557b0db2, cpu=0x00000001,
> cpuid=0x000306f3, apicid=0x00000002, bank=0x00000003
> 
> 
> In such a case, let's use the content of mcastatus_msg as error_msg instead.
> 
> # ras-mc-ctl --summary
> (snip)
> MCE records summary:
> 	1 Generic CACHE Level-2 Eviction Error errors
> # ras-mc-ctl --errors
> (snip)
> MCE events:
> 1 2015-06-12 02:39:04 +0900 error: Generic CACHE Level-2 Eviction Error, mcg
> mcgstatus= 0, mci Corrected_error Error_enabled, mcgcap=0x07000c16,
> status=0x9c0000000000017a, addr=0x204fffffff, misc=0x4004000000000080,
> walltime=0x557b1f22, cpu=0x00000001, cpuid=0x000306f3, apicid=0x00000002,
> bank=0x00000003
> 
> 
> Signed-off-by: Seiichi Ikarashi <s.ikarashi@jp.fujitsu.com>
> 
> diff --git a/ras-mce-handler.c b/ras-mce-handler.c
> index fb6db8a..32dfd32 100644
> --- a/ras-mce-handler.c
> +++ b/ras-mce-handler.c
> @@ -411,6 +411,9 @@ int ras_mce_event_handler(struct trace_seq *s,
>  	if (rc)
>  		return rc;
>  
> +	if (!*e.error_msg && *e.mcastatus_msg)
> +		mce_snprintf(e.error_msg, "%s", e.mcastatus_msg);
> +
>  	report_mce_event(ras, record, s, &e);
>  
>  #ifdef HAVE_SQLITE3

Acked-by: Aristeu Rozanski <aris@redhat.com>

-- 
Aristeu

--
To unsubscribe from this list: send the line "unsubscribe linux-edac" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]