[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-edac
Subject:    Re: [PATCH RESEND] e752x_edac: Simplify call to pci_get_device()
From:       Aristeu Rozanski <aris () redhat ! com>
Date:       2014-01-30 14:45:44
Message-ID: 20140130144544.GL15457 () redhat ! com
[Download RAW message or body]

On Thu, Jan 30, 2014 at 09:11:01AM +0100, Jean Delvare wrote:
> The last parameter, pvt->bridge_ck, is always NULL as far as I can
> see, so just use that.
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Mark Gross <mark.gross@intel.com>
> Cc: Doug Thompson <dougthompson@xmission.com>
> ---
> Already sent on: 2012-11-19
> 
> Note: not tested, no hardware.
> 
>  drivers/edac/e752x_edac.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-3.14-rc0.orig/drivers/edac/e752x_edac.c	2014-01-29 21:19:02.474491361 +0100
> +++ linux-3.14-rc0/drivers/edac/e752x_edac.c	2014-01-29 21:19:39.598301511 +0100
> @@ -1180,7 +1180,7 @@ static int e752x_get_devs(struct pci_dev
>  	struct pci_dev *dev;
>  
>  	pvt->bridge_ck = pci_get_device(PCI_VENDOR_ID_INTEL,
> -				pvt->dev_info->err_dev, pvt->bridge_ck);
> +				pvt->dev_info->err_dev, NULL);
>  
>  	if (pvt->bridge_ck == NULL) {
>  		pvt->bridge_ck = pci_scan_single_device(pdev->bus,
> 

I spent some minutes figuring that out while working in other problem.
Let's make sure nobody else does :)

ACK

-- 
Aristeu

--
To unsubscribe from this list: send the line "unsubscribe linux-edac" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]