[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-driver-devel
Subject: Re: [PATCH 01/01] drivers/staging/vt6656/main_usb.c: checkpatch warning
From: Randy Dunlap <rdunlap () infradead ! org>
Date: 2017-03-31 21:52:27
Message-ID: 5e28f35f-4ac9-8c0d-d211-47f8694a1367 () infradead ! org
[Download RAW message or body]
On 03/31/17 13:58, Chewie Lin wrote:
> Replace string with formatted arguments in the dev_warn() call. It removes
> the checkpatch warning.
Tell us what the warning was.
and then see if the patch fixes that warning.
> Signed-off-by: Chewie Lin <linsh@oregonstate.edu>
> ---
> drivers/staging/vt6656/main_usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
> index 9e074e9..2d9e7af 100644
> --- a/drivers/staging/vt6656/main_usb.c
> +++ b/drivers/staging/vt6656/main_usb.c
> @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv)
> status = usb_reset_device(priv->usb);
> if (status)
> dev_warn(&priv->usb->dev,
> - "usb_device_reset fail status=%d\n", status);
> + "%s=%d\n", "usb_device_reset fail status", status);
> }
>
> static void vnt_free_int_bufs(struct vnt_private *priv)
>
--
~Randy
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic