[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-driver-devel
Subject:    Re: [PATCH 4/6] drivers, staging, unisys Add visorbus module autoloading code
From:       Greg KH <gregkh () linuxfoundation ! org>
Date:       2015-07-31 23:07:57
Message-ID: 20150731230757.GA16153 () kroah ! com
[Download RAW message or body]

On Fri, Jul 24, 2015 at 12:06:54PM -0400, Benjamin Romer wrote:
> From: Prarit Bhargava <prarit@redhat.com>
> 
> This patch adds an module alias and a MODULE_DEVICE_TABLE to autoload the
> visorhba driver when an appropriate device is created by the visorbus.
> 
> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
> ---
> drivers/staging/unisys/visorhba/visorhba_main.c | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c \
> b/drivers/staging/unisys/visorhba/visorhba_main.c index 031c6fa..50ecdf2 100644
> --- a/drivers/staging/unisys/visorhba/visorhba_main.c
> +++ b/drivers/staging/unisys/visorhba/visorhba_main.c
> @@ -80,6 +80,8 @@ static struct visor_driver visorhba_driver = {
> 	.resume = visorhba_resume,
> 	.channel_interrupt = NULL,
> };
> +MODULE_DEVICE_TABLE(visorbus, visorhba_channel_types);
> +MODULE_ALIAS("visorbus:" SPAR_VHBA_CHANNEL_PROTOCOL_UUID_STR);

You shouldn't have to write MODULE_ALIAS lines "by hand", they should be
generated for you automagically from the MODULE_DEVICE_TABLE() define,
if you do it right.

You all didn't do it right :)

Please fix up.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel


[prev in list] [next in list] [prev in thread] [next in thread]