[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-driver-devel
Subject:    Re: [PATCH 28/28] staging: wilc1000: change data type of variable
From:       Greg KH <gregkh () linuxfoundation ! org>
Date:       2015-07-31 20:48:40
Message-ID: 20150731204840.GB1650 () kroah ! com
[Download RAW message or body]

On Fri, Jul 31, 2015 at 04:38:36PM +0900, Tony Cho wrote:
> From: glen lee <glen.lee@atmel.com>
> 
> drvHandler of u32 type is used to handle integer type pointer operation which
> cause build warnings.
> To use integer type varialbe as pointer, drvHandler data type need to be changed
> with uintptr_t type.
> 
> drivers/staging/wilc1000/host_interface.c: In function ‘NetworkInfoReceived':
> drivers/staging/wilc1000/host_interface.c:6767:15: warning: cast to pointer from \
> integer of different size [-Wint-to-pointer-cast] pstrWFIDrv = (tstrWILC_WFIDrv \
> *)drvHandler; ^
> drivers/staging/wilc1000/host_interface.c: In function ‘GnrlAsyncInfoReceived':
> drivers/staging/wilc1000/host_interface.c:6819:15: warning: cast to pointer from \
> integer of different size [-Wint-to-pointer-cast] pstrWFIDrv = (tstrWILC_WFIDrv \
> *)drvHandler; ^
> drivers/staging/wilc1000/host_interface.c: In function \
> ‘host_int_ScanCompleteReceived': \
> drivers/staging/wilc1000/host_interface.c:6878:15: warning: cast to pointer from \
> integer of different size [-Wint-to-pointer-cast] pstrWFIDrv = (tstrWILC_WFIDrv \
> *)drvHandler; 
> Signed-off-by: glen lee <glen.lee@atmel.com>
> Signed-off-by: Tony Cho <tony.cho@atmel.com>
> ---
> drivers/staging/wilc1000/host_interface.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/host_interface.c \
> b/drivers/staging/wilc1000/host_interface.c index b36f98c..668e47e 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -6760,7 +6760,7 @@ void NetworkInfoReceived(u8 *pu8Buffer, u32 u32Length)
> {
> 	s32 s32Error = WILC_SUCCESS;
> 	tstrHostIFmsg strHostIFmsg;
> -	u32 drvHandler;
> +	uintptr_t drvHandler;

This isn't a valid kernel type, use "unsigned int *" if that is what you mean.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel


[prev in list] [next in list] [prev in thread] [next in thread]