[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-driver-devel
Subject:    Re: [PATCH 1/4] staging: rtl8192u: fix comments
From:       Konrad Zapalowicz <bergo.torino () gmail ! com>
Date:       2014-12-31 19:28:42
Message-ID: 20141231192842.GC25819 () t400
[Download RAW message or body]

On 12/31, Lorenzo Stoakes wrote:
> On 31 December 2014 at 19:00, Konrad Zapalowicz <bergo.torino@gmail.com> wrote:
> >
> > You also fix the line length here which shall be the subject of a
> > separate patch as this is not C99 comments related change.
> >
> 
> Apologies - I missed this, will prepare a v2 with this separated out
> into a different patch. Relatedly, the intent was to fix whitespace
> issues rather than line length as I gather a specific line length
> limit is still a matter of debate in kernel style? I didn't want to

Usually the kernel people like the line length of 80 characters. There
are exceptions like for example for log messages because it makes easier
to search for it however most of the time 80 is good and whenever
possible it shall be applied.

You can read about it in the
https://www.kernel.org/doc/Documentation/CodingStyle document in second
chapter.

cheers,
konrad

> create additional noise by attempting to address that as well.
> 
> Best, Lorenzo
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[prev in list] [next in list] [prev in thread] [next in thread]