[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-driver-devel
Subject:    [PATCH] Staging: IIO: tsl2561: Drop unused module parameters
From:       jic23 () cam ! ac ! uk (Jonathan Cameron)
Date:       2009-09-26 14:12:38
Message-ID: 4ABE2156.4090609 () cam ! ac ! uk
[Download RAW message or body]

Hi Jean,

This driver is probably going to be dropped shortly anyway as I'll move
it over to the new als framework. On that version I'll make sure I don't
make this mistake again!

Thanks,

Jonathan

> The I2C_CLIENT_INSMOD macro is only useful for i2c drivers which
> implement device detection. The tsl2561 driver doesn't, so there
> is no point in calling it.
> 
> Signed-off-by: Jean Delvare <khali at linux-fr.org>
> Cc: Jonathan Cameron <jic23 at cam.ac.uk>
> ---
>  drivers/staging/iio/light/tsl2561.c |    4 ----
>  1 file changed, 4 deletions(-)
> 
> --- linux-2.6.32-pre.orig/drivers/staging/iio/light/tsl2561.c	2009-09-25 10:54:21.000000000 +0200
> +++ linux-2.6.32-pre/drivers/staging/iio/light/tsl2561.c	2009-09-25 14:18:05.000000000 +0200
> @@ -239,10 +239,6 @@ static int __devexit tsl2561_remove(stru
>  	return tsl2561_powerdown(client);
>  }
>  
> -static unsigned short normal_i2c[] = { 0x29, 0x39, 0x49, I2C_CLIENT_END };
> -
> -I2C_CLIENT_INSMOD;
> -
>  static const struct i2c_device_id tsl2561_id[] = {
>  	{ "tsl2561", 0 },
>  	{ }
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]