[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-driver-devel
Subject:    [PATCH 1/3] Staging: rtl8187se: Move rtl8187se/ieee80211/* to
From:       gregkh () suse ! de (Greg KH)
Date:       2009-08-28 17:19:50
Message-ID: 20090828171950.GA5227 () suse ! de
[Download RAW message or body]

On Fri, Aug 28, 2009 at 12:23:25PM -0400, Anders Kaseorg wrote:
> The current rtl8187se Makefile builds objects in the ieee80211
> subdirectory, which is a violation of the kbuild specification,
> according to Documentation/kbuild/makefiles.txt:

All of drivers/staging/ violates the kernel coding style "rules", so
this is not a real issue :)

I'd prefer to not accept this and the other move patch, as the code
should just be dropped entirely and the in-kernel ieee80211 code used
instead.  Keeping it in a subdirectory like it is makes it more obvious
as to what needs to be done here.

I will take your "remove unused files" patch, that is good to do.

Also note that there is a rtl8192e driver in the tree that also does
this same thing (have ieee80211 code in a subdir).

I'm trying to work with RealTek to keep this from happening in their
future drivers, but communication with them is slow.

thanks,

greg k-h

[prev in list] [next in list] [prev in thread] [next in thread]