[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-driver-devel
Subject:    [PATCH] octeon: false positive timeout
From:       ralf () linux-mips ! org (Ralf Baechle)
Date:       2009-08-26 16:09:55
Message-ID: 20090826160955.GA26668 () linux-mips ! org
[Download RAW message or body]

On Wed, Aug 26, 2009 at 08:45:10AM -0700, David Daney wrote:

> Roel Kluin wrote:
>> If we reach the test just below the loop with a `timeout' value of 0,
>> this does not mean that the timeout caused the loop to end, but rather
>> the `smi_rd.s.pending', in the last iteration. If timeout caused the
>> loop to end, then `timeout' is -1, not 0. 
>>
>> Since this can occur only in the last iteration, it is not very likely
>> to be a problem. By changing the post- to prefix decrement we ensure
>> that a timeout of 0 does mean it timed out.
>>
>> Signed-off-by: Roel Kluin <roel.kluin at gmail.com>
>
> Acked-by: David Daney <ddaney at caviumnetworks.com>

Thanks, applied.

   Ralf

[prev in list] [next in list] [prev in thread] [next in thread]