[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-doc
Subject:    Re: [PATCH v3 01/35] lib/string_helpers: Add flags param to string_get_size()
From:       Andy Shevchenko <andy.shevchenko () gmail ! com>
Date:       2024-02-29 20:54:40
Message-ID: ZeDvEKtlB73mnOYy () smile ! fi ! intel ! com
[Download RAW message or body]

On Tue, Feb 13, 2024 at 05:06:24PM -0500, Kent Overstreet wrote:
> On Tue, Feb 13, 2024 at 10:26:48AM +0200, Andy Shevchenko wrote:
> > On Mon, Feb 12, 2024 at 11:39 PM Suren Baghdasaryan <surenb@google.com> wrote:

> > It seems most of my points from the previous review were refused...
> 
> Look, Andy, this is a pretty tiny part of the patchset, yet it's been
> eating up a pretty disproprortionate amount of time and your review
> feedback has been pretty unhelpful - asking for things to be broken up
> in ways that would not be bisectable, or (as here) re-asking the same
> things that I've already answered and that should've been obvious.
> 
> The code works. If you wish to complain about anything being broken, or
> if you can come up with anything more actionable than what you've got
> here, I will absolutely respond to that, but otherwise I'm just going to
> leave things where they sit.

I do not understand why I should do *your* job.
Nevertheless, I have just sent my version of this change.
Enjoy!

-- 
With Best Regards,
Andy Shevchenko



[prev in list] [next in list] [prev in thread] [next in thread]