[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-doc
Subject:    Re: [PATCH 3/3] doc-rst: Fix recursive make invocation from macros
From:       Markus Heiser <markus.heiser () darmarit ! de>
Date:       2017-01-31 9:14:39
Message-ID: 2ADE9B9C-0975-4613-A720-F37EF4B01185 () darmarit ! de
[Download RAW message or body]


Am 31.01.2017 um 01:18 schrieb Ben Hutchings <ben@decadent.org.uk>:

> In any case where we recurse but don't mention $(MAKE) literally in
> the recipe, we need to add a '+' at the start of the command to ensure
> that parallel makes and various other options work properly.

Tested-by: Markus Heiser <markus.heiser@darmarit.de>

Thanks!

for those like me, didn't know what Ben means with ".. and various other options"
here is the description :)

 https://www.gnu.org/software/make/manual/make.html#How-the-MAKE-Variable-Works

-- Markus --


> 
> Fixes: 609afe6b49ef ("Documentation/sphinx: build the media intermediate ...")
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> Documentation/Makefile.sphinx | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/Makefile.sphinx b/Documentation/Makefile.sphinx
> index 02d84e6dc7fc..e14d82a98062 100644
> --- a/Documentation/Makefile.sphinx
> +++ b/Documentation/Makefile.sphinx
> @@ -66,10 +66,10 @@ quiet_cmd_sphinx = SPHINX  $@ --> file://$(abspath $(BUILDDIR)/$3/$4)
> 	$(abspath $(BUILDDIR)/$3/$4)
> 
> htmldocs:
> -	@$(foreach var,$(SPHINXDIRS),$(call loop_cmd,sphinx,html,$(var),,$(var)))
> +	@+$(foreach var,$(SPHINXDIRS),$(call loop_cmd,sphinx,html,$(var),,$(var)))
> 
> latexdocs:
> -	@$(foreach var,$(SPHINXDIRS),$(call loop_cmd,sphinx,latex,$(var),latex,$(var)))
> +	@+$(foreach var,$(SPHINXDIRS),$(call loop_cmd,sphinx,latex,$(var),latex,$(var)))
> 
> ifeq ($(HAVE_PDFLATEX),0)
> 
> @@ -85,10 +85,10 @@ pdfdocs: latexdocs
> endif # HAVE_PDFLATEX
> 
> epubdocs:
> -	@$(foreach var,$(SPHINXDIRS),$(call loop_cmd,sphinx,epub,$(var),epub,$(var)))
> +	@+$(foreach var,$(SPHINXDIRS),$(call loop_cmd,sphinx,epub,$(var),epub,$(var)))
> 
> xmldocs:
> -	@$(foreach var,$(SPHINXDIRS),$(call loop_cmd,sphinx,xml,$(var),xml,$(var)))
> +	@+$(foreach var,$(SPHINXDIRS),$(call loop_cmd,sphinx,xml,$(var),xml,$(var)))
> 
> # no-ops for the Sphinx toolchain
> sgmldocs:

--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]